Improve investment form #4580
Merged
Improve investment form #4580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
improve-investment-form
branch
2 times, most recently
from
0929071
to
4e7492e
Compare
javierm
force-pushed
the
improve-investment-form
branch
from
4e7492e
to
5764667
Compare
javierm
force-pushed
the
improve-investment-form
branch
7 times, most recently
from
de36b5f
to
bd0478a
Compare
javierm
force-pushed
the
full_width
branch
3 times, most recently
from
741ab86
to
1c69b86
Compare
javierm
force-pushed
the
improve-investment-form
branch
from
bd0478a
to
b66b279
Compare
javierm
force-pushed
the
full_width
branch
3 times, most recently
from
f0fa3d6
to
ef1884b
Compare
javierm
force-pushed
the
improve-investment-form
branch
from
b66b279
to
46e827a
Compare
javierm
force-pushed
the
improve-investment-form
branch
from
46e827a
to
28f39a3
Compare
javierm
force-pushed
the
improve-investment-form
branch
2 times, most recently
from
6fe6efd
to
6f2fb5e
Compare
javierm
force-pushed
the
full_width
branch
6 times, most recently
from
47e7695
to
fef38bb
Compare
javierm
force-pushed
the
improve-investment-form
branch
2 times, most recently
from
052e467
to
b8cf128
Compare
javierm
force-pushed
the
full_width
branch
2 times, most recently
from
aa3888b
to
b8ee325
Compare
javierm
force-pushed
the
improve-investment-form
branch
from
b8cf128
to
6f406b2
Compare
Rails automatically adds it when using file fields inside a form.
javierm
force-pushed
the
improve-investment-form
branch
2 times, most recently
from
df93500
to
823cc37
Compare
We don't need any row classes anymore because the <body> already has a maximum width. As for columns, we only have one column in this form, so we don't need them either. Besides, the form's parent element already has a padding. Although most CONSUL installation don't enable the translation interface, we're adding some code to take this case into account.
One of them was less wide than the other one. We're still only adding the heading to the form for the new investment, just like in the original budgets redesign.
No need to accept the terms when updating the investment.
javierm
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Visual Changes