New budgets administration and front views #4198
Closed
+95
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 12, 2020
decabeza
force-pushed
the
admin_budgets
branch
2 times, most recently
from
b8aa5ce
to
d426f65
Compare
decabeza
force-pushed
the
admin_budgets
branch
2 times, most recently
from
8ca5a5c
to
f1d698b
Compare
javierm
force-pushed
the
admin_budgets
branch
4 times, most recently
from
5493486
to
b273fb5
Compare
This was referenced Feb 16, 2021
This was referenced Mar 15, 2021
This was referenced May 6, 2021
Merged
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/assets/stylesheets/admin.scss
Outdated
| .table-actions { | ||
| margin-top: rem-calc(26); | ||
|
|
||
| > :first-child { |
There was a problem hiding this comment.
Nesting should be no greater than 4, but was 5
app/assets/stylesheets/admin.scss
Outdated
| .table-actions { | ||
| margin-top: rem-calc(26); | ||
|
|
||
| > :first-child { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 5, but was 6
app/assets/stylesheets/admin.scss
Outdated
| margin-left: rem-calc(3);; | ||
| } | ||
|
|
||
| > :not(:first-child) { |
There was a problem hiding this comment.
Nesting should be no greater than 4, but was 5
app/assets/stylesheets/admin.scss
Outdated
| margin-left: rem-calc(3);; | ||
| } | ||
|
|
||
| > :not(:first-child) { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 5, but was 6
app/assets/stylesheets/admin.scss
Outdated
| margin-top: rem-calc(26); | ||
|
|
||
| > :first-child { | ||
| margin-left: rem-calc(3);; |
There was a problem hiding this comment.
Declaration should be terminated by a single semicolon
javierm
force-pushed
the
admin_budgets
branch
2 times, most recently
from
8690efc
to
3a23f55
Compare
javierm
force-pushed
the
admin_budgets
branch
from
fc766eb
to
8772658
Compare
Note one of the tests dealing with random results is a bit flaky; since it's a permutation selecting 7 objects out of 12, it will fail about once every 4 million times. We think this is acceptable. Co-Authored-By: Julian Nicolas Herrero <microweb10@gmail.com>
Co-authored-by: decabeza <alberto@decabeza.es>
Co-Authored-By: Julian Nicolas Herrero <microweb10@gmail.com>
|
I think the only pending pull request related to this one is pull request #4686, so closing this one. Thank you @decabeza @microweb10 @Senen @taitus! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectives
This PR refactor and redesign the Participative Budgets. This code introduces a lot of changes for the administration panel and the user's front views.
Here is the list of the most relevant changes. Don't miss the screenshots in the Visual Changes section! 😌
Participatory budgets creation by steps
Now it's possible to create budgets with "single heading" and "multiple headings" Now, the creation of the budget, is divided by steps:
budget > group > heading > phases.Refactor participatory budgets in draft mode
Previously the draft mode was a phase of the PB, but that had some limitations.
Now the phase drafting disappears, and the PB can have the status published or not published (in draft mode).
That will give more flexibility to navigate through the different phases and see how it looks for administrators before
publishing the PB, and everybody can see.
By default, the PB is in draft mode, so it gives you the flexibility to adjust and modify anything before publishing it.
Groups and headings CRUD from budget view
Before, users needed to navigate to the list of groups to add, edit, or delete a group.
Also, they need to navigate to the list of groups first, and then to the list of headings for that group to add, edit, or delete a heading.
Now, it's possible to do all these actions for any group or heading from the participatory budget view to bring simplicity and to reduce the number of clicks from a user perspective.
Unify budget landing pages
There was a big difference between the current budget and a specific budget landing page, and this didn't make too much sense. Also, it was not possible to know how a draft participatory budget will look before publishing.
By unifying those two views now they will look quite similar, and it will be possible for administrators to preview any draft budget and to know how the budget will look like before actually publishing it.
Other changes in participatory budgets
At last but not least
A new design for the admin and front views! 🎉
Visual Changes
WIP more upcoming gifs soon! 🎨
Admin panel budgets index
Admin panel budgets edit
New front view for the users