[WIP] Budget Stats generation & display #1712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👏👏👏 |
bertocq
force-pushed
the
feature/budget_stats
branch
from
423b1be
to
b9dce7d
Compare
bertocq
force-pushed
the
feature/budget_stats
branch
4 times, most recently
from
2003875
to
c4312f0
Compare
bertocq
changed the title
bertocq
changed the title
…and finished budget
bertocq
force-pushed
the
feature/budget_stats
branch
from
8e3ec5c
to
e6490b1
Compare
voodoorai2000
approved these changes
Jul 17, 2017
Closed
|
We'll be taking a second look at stats in a global level soon, this will be improved then. Frozen for now.. |
javierm
added a commit
to javierm/consul
that referenced
this pull request
Nov 22, 2018
…_milestoneable_code Make milestones code reusable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
What
Madrid's fork got some nice Budget Stats view, on deprecated Spending Proposal model. We want them for the new Budget model and usage.
Getting current specific code from https://github.com/AyuntamientoMadrid/consul/blob/master/app/controllers/spending_proposals_controller.rb#L71 and specific view. And moving on from Geozones usage on to Headings usage for population/district specifics.
How
Adding a missing ballot_lines_count counter_cache to Budget::Ballot::Line relationship with Budget::Ballot for
ballotersstatsAdding votes and ballots to Budget::Investments on dev_seeds so local development can try this things. Maybe its not done quite nice or good... need to invest time in dev_seeds to completly get all scenarios done right.
Adding a Budget Stats controller, route and ability for anyone to see stats when Budget is either on ballots reviewing or finished phases.
Adding a Budget::Stats class and its view (although I need some help with this, since styles are not my thing :D, also many stat names need to be fixed and maybe some style class names as well) @decabeza you MVP!!
Adding link to results page on tabs under header
Screenshots
Test
Incoming from Madrid.
Deployment
As usual
Warnings
Still some bits to fix on the Results side... new PR will follow