Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added physical votes to stats #1544

Merged
merged 1 commit into from
Jul 5, 2018
Merged

Added physical votes to stats #1544

merged 1 commit into from
Jul 5, 2018

Conversation

MariaCheca
Copy link

References

Related issue #1527

Objectives

  • Added physical votes to budget's statistics.
  • Added tests for stats.

@MariaCheca MariaCheca added this to Review in Roadmap Jul 4, 2018
@voodoorai2000 voodoorai2000 merged commit 47df9f2 into master Jul 5, 2018
@voodoorai2000 voodoorai2000 deleted the budget_stats_improvements branch July 5, 2018 11:26
@MariaCheca MariaCheca moved this from Review to Backport in Roadmap Jul 11, 2018
@decabeza
Copy link

⚠️ Beware when backporting this. On CONSUL there is still no budget stats (Pending PR consuldemocracy#1712)

@voodoorai2000 voodoorai2000 mentioned this pull request Jul 26, 2018
Closed
@javierm
Copy link

javierm commented Sep 12, 2018

⚠️ When backporting, backport at least some parts of #1597 as well, since it fixes some test database issues related to this PR.

@mlovic mlovic mentioned this pull request Nov 13, 2018
Merged
@javierm javierm mentioned this pull request Apr 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voodoorai2000 voodoorai2000 voodoorai2000 approved these changes

Assignees
No one assigned
Labels
Backport Needed
Projects
Roadmap
Backport
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MariaCheca @decabeza @javierm @voodoorai2000