Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Poll Final Recounts, replace with Total Results #1885

Merged
merged 25 commits into from
Sep 20, 2017
Merged

Remove Poll Final Recounts, replace with Total Results #1885

merged 25 commits into from
Sep 20, 2017

Commits on Sep 18, 2017

  1. Replace FinalResult with TotalResult at admin BoothAssignment show

    @bertocq
    bertocq committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    f27fcc7 View commit details
    Browse the repository at this point in the history

  2. Replace FinalResult with TotalResult at admin Poll Recounts page

    @bertocq
    bertocq committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    851d397 View commit details
    Browse the repository at this point in the history

  3. Remove no longer used functions

    @bertocq
    bertocq committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    1c1bb7b View commit details
    Browse the repository at this point in the history

  4. Remove final result usage on admin poll officer assignments results

    @bertocq
    bertocq committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    a3bf69e View commit details
    Browse the repository at this point in the history

  5. Totally remove Poll::FinalRecount model, table spec and factory

    @bertocq
    bertocq committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    2e3b5aa View commit details
    Browse the repository at this point in the history

  6. Fix admin poll officers assignments by officer view

    @bertocq
    bertocq committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    630a325 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2017

  1. Remove document cached_attachment value after destroy_upload action.

    @Senen @bertocq
    Senen authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    6e3f9f9 View commit details
    Browse the repository at this point in the history

  2. Use snake_case for method names

    @bertocq
    bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    6082147 View commit details
    Browse the repository at this point in the history

  3. Use correct Predicate name on function

    @bertocq
    bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    c5671ed View commit details
    Browse the repository at this point in the history

  4. Correct end at file ending

    @bertocq
    bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    d9575ba View commit details
    Browse the repository at this point in the history

  5. Use datetime always with zone

    @bertocq
    bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    bf37b8e View commit details
    Browse the repository at this point in the history

  6. moves author actions to sidebar on proposal show

    @decabeza @bertocq
    decabeza authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    adc71fa View commit details
    Browse the repository at this point in the history

  7. fixes margin of tags on proposal show

    @decabeza @bertocq
    decabeza authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    b5d0a82 View commit details
    Browse the repository at this point in the history

  8. refactors proposal helper and use correctly on proposal show view

    @decabeza @bertocq
    decabeza authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    fc3eac7 View commit details
    Browse the repository at this point in the history

  9. avoids use class variables on helper

    @decabeza @bertocq
    decabeza authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    42749b0 View commit details
    Browse the repository at this point in the history

  10. Remove Netbeans folder from .gitignore 

    Why:

* IDE/Text editor specific files and folders to be ignored should be on each developer's personal .gitignore_global file

How:

* If you're affected by this change, check https://help.github.com/articles/ignoring-files/#create-a-global-gitignore
    @bertocq
    bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    c1543c7 View commit details
    Browse the repository at this point in the history

  11. fixes flaky spec 

    Reactivates feature setting after spec
    @voodoorai2000 @bertocq
    voodoorai2000 authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    8db8049 View commit details
    Browse the repository at this point in the history

  12. removes obsolete legislations specs 

    Obsolete and flaky!
    @voodoorai2000 @bertocq
    voodoorai2000 authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    c128a0f View commit details
    Browse the repository at this point in the history

  13. fixes flaky spec 

    Using correct resource in path
    @voodoorai2000 @bertocq
    voodoorai2000 authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    d1aa01b View commit details
    Browse the repository at this point in the history

  14. removes unused expectation

    @voodoorai2000 @bertocq
    voodoorai2000 authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    aee34e6 View commit details
    Browse the repository at this point in the history

  15. fixes flaky spec 

    Visits directly the page to avoid flakiness
    @voodoorai2000 @bertocq
    voodoorai2000 authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    92333e5 View commit details
    Browse the repository at this point in the history

  16. fixes flaky spec 

    Maybe using `build` instead of `create` was confusing the spec
    @voodoorai2000 @bertocq
    voodoorai2000 authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    6de47e7 View commit details
    Browse the repository at this point in the history

  17. fixes flaky spec 

    Adds random number to the proposal’s title, to avoid js popup
displaying similar proposals
    @voodoorai2000 @bertocq
    voodoorai2000 authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    882723a View commit details
    Browse the repository at this point in the history

  18. precompile assets in test environment 

    Usually the first spec that visits a page fails with a timeout.
Hopefully it was due to having to compile assets at runtime and this helps to fix it
    @voodoorai2000 @bertocq
    voodoorai2000 authored and bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    3105bd9 View commit details
    Browse the repository at this point in the history

  19. Fix wrong spectations after final result swap for total result

    @bertocq
    bertocq committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    9c6a974 View commit details
    Browse the repository at this point in the history