Remove Poll Final Recounts, replace with Total Results #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome 🎉 |
voodoorai2000
approved these changes
Sep 19, 2017
Why: * IDE/Text editor specific files and folders to be ignored should be on each developer's personal .gitignore_global file How: * If you're affected by this change, check https://help.github.com/articles/ignoring-files/#create-a-global-gitignore
Reactivates feature setting after spec
Obsolete and flaky!
Using correct resource in path
Visits directly the page to avoid flakiness
Maybe using `build` instead of `create` was confusing the spec
Adds random number to the proposal’s title, to avoid js popup displaying similar proposals
Usually the first spec that visits a page fails with a timeout. Hopefully it was due to having to compile assets at runtime and this helps to fix it
javierm
pushed a commit
to javierm/consul
that referenced
this pull request
Mar 6, 2019
…alize_setting_in_development_environment Initialize settings in development environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
Ongoing Polls refactor effort
What
How
Replaced "Final Recount" usage on Admin Poll panels with Poll::TotalResult.
.firstattotal_recount = @booth_assignment.total_results.where(date: voting_date).first.amountat /app/views/admin/poll/booth_assignments/show.html.erb is not good, have to ask about scenarios where there could be more than oneRenamed properly some labels from "Final" to "Total"
Screenshots
Poll recounting tab
Poll officer assignment by officer details
Poll booth details
Test
Deployment
Warnings