Add rubocop spacing rules #3631

javierm · 2019-06-23T18:47:05Z

References

Depends on Apply Rubocop rules #3629

Objectives

Make it easier to detect code spacing issues in pull requests
Apply guidelines developers have agreed upon to existing code

Notes

In another pull request we'll make the code DRYer by removing the rules from the .erb-lint.yml file. We cannot do it yet because the option to do so in ERB Lint doesn't seem to work with Ruby 2.3.2.

houndci-bot · 2019-06-23T18:47:44Z

spec/models/proposal_spec.rb

      end
    end

    it "does not register vote for archived proposals" do
      user = create(:user, verified_at: Time.current)
      archived_proposal = create(:proposal, :archived)

-      expect {archived_proposal.register_vote(user, "yes")}.to change{proposal.reload.votes_for.size}.by(0)
+      expect { archived_proposal.register_vote(user, "yes") }.to change { proposal.reload.votes_for.size }.by(0)


Metrics/LineLength: Line is too long. [112/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-06-23T18:47:45Z

spec/models/poll/shift_spec.rb

@@ -63,7 +63,7 @@
      booth_assignment1 = create(:poll_booth_assignment, poll: poll, booth: booth)
      booth_assignment2 = create(:poll_booth_assignment, poll: poll2, booth: booth)

-      expect { create(:poll_shift, booth: booth, officer: officer, date: Date.current) }.to change {Poll::OfficerAssignment.all.count}.by(2)
+      expect { create(:poll_shift, booth: booth, officer: officer, date: Date.current) }.to change { Poll::OfficerAssignment.all.count }.by(2)


Metrics/LineLength: Line is too long. [142/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-06-23T18:47:45Z

spec/models/debate_spec.rb

      end

      it "does not increase anonymous votes counter " do
        user = create(:user)
-        expect {debate.register_vote(user, "yes")}.not_to change {debate.reload.cached_anonymous_votes_total}
+        expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.cached_anonymous_votes_total }


Metrics/LineLength: Line is too long. [113/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-06-23T18:47:45Z

spec/models/debate_spec.rb

      end

      it "increases anonymous votes counter" do
        user = create(:user)
-        expect {debate.register_vote(user, "yes")}.to change {debate.reload.cached_anonymous_votes_total}.by(1)
+        expect { debate.register_vote(user, "yes") }.to change { debate.reload.cached_anonymous_votes_total }.by(1)


Metrics/LineLength: Line is too long. [115/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-06-23T18:47:45Z

spec/models/debate_spec.rb

      end

      it "does not increase anonymous votes counter " do
        user = create(:user, verified_at: Time.current)
-        expect {debate.register_vote(user, "yes")}.not_to change{debate.reload.cached_anonymous_votes_total}
+        expect { debate.register_vote(user, "yes") }.not_to change { debate.reload.cached_anonymous_votes_total }


Metrics/LineLength: Line is too long. [113/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-06-23T18:47:46Z

lib/manager_authenticator.rb

@@ -1,27 +1,27 @@
 class ManagerAuthenticator

  def initialize(data = {})
-    @manager = {login: data[:login], user_key: data[:clave_usuario], date: data[:fecha_conexion]}.with_indifferent_access
+    @manager = { login: data[:login], user_key: data[:clave_usuario], date: data[:fecha_conexion] }.with_indifferent_access


Metrics/LineLength: Line is too long. [123/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-06-23T18:47:47Z

spec/lib/manager_authenticator_spec.rb

      allow(authenticator).to receive(:application_authorized?).and_return(true)
      allow(authenticator.send(:client)).to receive(:call).with(:get_status_user_data, message: message)
      authenticator.auth
    end

    it "calls the permissions check method" do
      allow(authenticator).to receive(:manager_exists?).and_return(true)
-      allow(authenticator.send(:client)).to receive(:call).with(:get_applications_user_list, message: { ub: {user_key: "31415926"} })
+      allow(authenticator.send(:client)).to receive(:call).with(:get_applications_user_list, message: { ub: { user_key: "31415926" }})


Metrics/LineLength: Line is too long. [134/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-06-23T18:47:47Z

spec/features/users_auth_spec.rb

-      let(:twitter_hash){ {provider: "twitter", uid: "12345", info: {name: "manuela"}} }
-      let(:twitter_hash_with_email){ {provider: "twitter", uid: "12345", info: {name: "manuela", email: "manuelacarmena@example.com"}} }
+      let(:twitter_hash) { { provider: "twitter", uid: "12345", info: { name: "manuela" }} }
+      let(:twitter_hash_with_email) { { provider: "twitter", uid: "12345", info: { name: "manuela", email: "manuelacarmena@example.com" }} }


Metrics/LineLength: Line is too long. [140/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-06-23T18:47:47Z

spec/features/legislation/resume_spec.rb

      annotation2 = create(:legislation_annotation,
                           draft_version: draft_version_2,
-                           ranges: [{"start" => "/p[1]", "startOffset" => 12, "end" => "/p[1]", "endOffset" => 19}])
+                           ranges: [{ "start" => "/p[1]", "startOffset" => 12, "end" => "/p[1]", "endOffset" => 19 }])


Metrics/LineLength: Line is too long. [118/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-06-23T18:47:47Z

spec/features/legislation/resume_spec.rb

      annotation1 = create(:legislation_annotation,
                           draft_version: draft_version_2, text: "hola",
-                           ranges: [{"start" => "/p[1]", "startOffset" => 5, "end" => "/p[1]", "endOffset" => 10}])
+                           ranges: [{ "start" => "/p[1]", "startOffset" => 5, "end" => "/p[1]", "endOffset" => 10 }])


Metrics/LineLength: Line is too long. [117/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T00:22:05Z

spec/features/comments/legislation_annotations_spec.rb

    end
    let!(:annotation2) do
      create(:legislation_annotation, draft_version: draft_version, text: "my other annotation",
-                                      ranges: [{"start" => "/p[1]", "startOffset" => 1, "end" => "/p[1]", "endOffset" => 10}])
+                                      ranges: [{ "start" => "/p[1]", "startOffset" => 1, "end" => "/p[1]", "endOffset" => 10 }])


Metrics/LineLength: Line is too long. [128/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T00:22:05Z

spec/features/comments/legislation_annotations_spec.rb

@@ -623,11 +623,11 @@
    let!(:draft_version) { create(:legislation_draft_version, :published) }
    let!(:annotation1) do
      create(:legislation_annotation, draft_version: draft_version, text: "my annotation",
-                                      ranges: [{"start" => "/p[1]", "startOffset" => 1, "end" => "/p[1]", "endOffset" => 5}])
+                                      ranges: [{ "start" => "/p[1]", "startOffset" => 1, "end" => "/p[1]", "endOffset" => 5 }])


Metrics/LineLength: Line is too long. [127/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T00:22:05Z

spec/features/legislation/draft_versions_spec.rb

      @annotation = create(:legislation_annotation, draft_version: @draft_version, text: "my other annotation", quote: "audiam",
-                                                    ranges: [{"start" => "/p[3]", "startOffset" => 6, "end" => "/p[3]", "endOffset" => 11}])
+                                                    ranges: [{ "start" => "/p[3]", "startOffset" => 6, "end" => "/p[3]", "endOffset" => 11 }])


Metrics/LineLength: Line is too long. [142/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T00:22:05Z

spec/features/legislation/draft_versions_spec.rb

@@ -301,9 +301,9 @@
    before do
      @draft_version = create(:legislation_draft_version, :published)
      create(:legislation_annotation, draft_version: @draft_version, text: "my annotation", quote: "ipsum",
-                                      ranges: [{"start" => "/p[1]", "startOffset" => 6, "end" => "/p[1]", "endOffset" => 11}])
+                                      ranges: [{ "start" => "/p[1]", "startOffset" => 6, "end" => "/p[1]", "endOffset" => 11 }])


Metrics/LineLength: Line is too long. [128/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T00:22:05Z

spec/features/legislation/draft_versions_spec.rb

        @draft_version_2 = create(:legislation_draft_version, :published, process: @process,
                                                                          title: "Version 2", body: "Text with quote for version 2")
        create(:legislation_annotation, draft_version: @draft_version_2, text: "annotation for version 2", quote: "quote for version 2",
-                                        ranges: [{"start" => "/p[1]", "startOffset" => 11, "end" => "/p[1]", "endOffset" => 30}])
+                                        ranges: [{ "start" => "/p[1]", "startOffset" => 11, "end" => "/p[1]", "endOffset" => 30 }])


Metrics/LineLength: Line is too long. [131/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T00:22:07Z

spec/features/legislation/draft_versions_spec.rb

      create(:legislation_annotation, draft_version: draft_version, text: "my other annotation",
-                                      ranges: [{"start" => "/p[1]", "startOffset" => 12, "end" => "/p[1]", "endOffset" => 19}])
+                                      ranges: [{ "start" => "/p[1]", "startOffset" => 12, "end" => "/p[1]", "endOffset" => 19 }])


Metrics/LineLength: Line is too long. [129/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T00:22:07Z

spec/features/legislation/draft_versions_spec.rb

@@ -184,9 +184,9 @@
    scenario "View annotations and comments" do
      draft_version = create(:legislation_draft_version, :published)
      annotation1 = create(:legislation_annotation, draft_version: draft_version, text: "my annotation",
-                                                    ranges: [{"start" => "/p[1]", "startOffset" => 5, "end" => "/p[1]", "endOffset" => 10}])
+                                                    ranges: [{ "start" => "/p[1]", "startOffset" => 5, "end" => "/p[1]", "endOffset" => 10 }])


Metrics/LineLength: Line is too long. [142/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T00:22:07Z

app/models/budget/investment.rb

@@ -73,7 +73,7 @@ class Investment < ApplicationRecord
    scope :without_valuator,            -> { valuation_open.without_valuator_group.where(valuator_assignments_count: 0) }
    scope :under_valuation,             -> { valuation_open.valuating.where("administrator_id IS NOT ?", nil) }
    scope :managed,                     -> { valuation_open.where(valuator_assignments_count: 0).where("administrator_id IS NOT ?", nil) }
-    scope :valuating,                   -> { valuation_open.where("valuator_assignments_count > 0 OR valuator_group_assignments_count > 0" ) }
+    scope :valuating,                   -> { valuation_open.where("valuator_assignments_count > 0 OR valuator_group_assignments_count > 0") }


Metrics/LineLength: Line is too long. [141/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T00:22:08Z

spec/features/legislation/resume_spec.rb

@@ -180,13 +180,13 @@
                               status: "published")
      annotation0 = create(:legislation_annotation,
                           draft_version: draft_version_1, text: "my annotation123",
-                           ranges: [{"start" => "/p[1]", "startOffset" => 5, "end" => "/p[1]", "endOffset" => 10}])
+                           ranges: [{ "start" => "/p[1]", "startOffset" => 5, "end" => "/p[1]", "endOffset" => 10 }])


Metrics/LineLength: Line is too long. [117/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T00:22:08Z

spec/features/budgets/investments_spec.rb

-          bdgt_invest3 = create(:budget_investment, heading: heading,title: "Save the forest")
+          bdgt_invest1 = create(:budget_investment, heading: heading, title: "Get Schwifty",   author: ana,  created_at: 1.minute.ago)
+          bdgt_invest2 = create(:budget_investment, heading: heading, title: "Hello Schwifty", author: john, created_at: 2.days.ago)
+          bdgt_invest3 = create(:budget_investment, heading: heading, title: "Save the forest")


Lint/UselessAssignment: Useless assignment to variable - bdgt_invest3. Did you mean bdgt_invest1? (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)

houndci-bot · 2019-07-05T01:26:46Z

spec/features/budgets/investments_spec.rb

-          bdgt_invest2 = create(:budget_investment, heading: heading,title: "Hello Schwifty", author: john, created_at: 2.days.ago)
-          bdgt_invest3 = create(:budget_investment, heading: heading,title: "Save the forest")
+          bdgt_invest1 = create(:budget_investment, heading: heading, title: "Get Schwifty",   author: ana,  created_at: 1.minute.ago)
+          bdgt_invest2 = create(:budget_investment, heading: heading, title: "Hello Schwifty", author: john, created_at: 2.days.ago)


Lint/UselessAssignment: Useless assignment to variable - bdgt_invest2. Did you mean bdgt_invest1? (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
Metrics/LineLength: Line is too long. [132/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:26:46Z

spec/features/budgets/investments_spec.rb

-          bdgt_invest1 = create(:budget_investment, heading: heading,title: "Get Schwifty",   author: ana,  created_at: 1.minute.ago)
-          bdgt_invest2 = create(:budget_investment, heading: heading,title: "Hello Schwifty", author: john, created_at: 2.days.ago)
-          bdgt_invest3 = create(:budget_investment, heading: heading,title: "Save the forest")
+          bdgt_invest1 = create(:budget_investment, heading: heading, title: "Get Schwifty",   author: ana,  created_at: 1.minute.ago)


Metrics/LineLength: Line is too long. [134/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:26:46Z

app/models/poll/officer_assignment.rb

-    scope :by_date, ->(date){ where(date: date) }
+    scope :by_officer, ->(officer) { where(officer_id: officer.id) }
+    scope :by_poll,  ->(poll) { joins(:booth_assignment).where("poll_booth_assignments.poll_id" => poll.id) }
+    scope :by_booth, ->(booth) { joins(:booth_assignment).where("poll_booth_assignments.booth_id" => booth.id) }


Metrics/LineLength: Line is too long. [112/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:26:47Z

app/models/budget/stats.rb

-    groups[:total][:percentage_participants_every_phase] = groups.collect {|_k, v| v[:percentage_participants_every_phase]}.sum
+    groups[:total][:percentage_participants_support_phase] = groups.collect { |_k, v| v[:percentage_participants_support_phase] }.sum
+    groups[:total][:percentage_participants_vote_phase] = groups.collect { |_k, v| v[:percentage_participants_vote_phase] }.sum
+    groups[:total][:percentage_participants_every_phase] = groups.collect { |_k, v| v[:percentage_participants_every_phase] }.sum


Metrics/LineLength: Line is too long. [129/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:26:47Z

app/models/budget/stats.rb

-    groups[:total][:percentage_participants_vote_phase] = groups.collect {|_k, v| v[:percentage_participants_vote_phase]}.sum
-    groups[:total][:percentage_participants_every_phase] = groups.collect {|_k, v| v[:percentage_participants_every_phase]}.sum
+    groups[:total][:percentage_participants_support_phase] = groups.collect { |_k, v| v[:percentage_participants_support_phase] }.sum
+    groups[:total][:percentage_participants_vote_phase] = groups.collect { |_k, v| v[:percentage_participants_vote_phase] }.sum


Metrics/LineLength: Line is too long. [127/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:26:48Z

app/helpers/documents_helper.rb

@@ -27,7 +27,7 @@ def render_destroy_document_link(builder, document)
                  remote: true,
                  class: "delete remove-cached-attachment"
    else
-      link_to_remove_association document.new_record? ? t("documents.form.cancel_button") : t("documents.form.delete_button") , builder, class: "delete remove-document"
+      link_to_remove_association document.new_record? ? t("documents.form.cancel_button") : t("documents.form.delete_button"), builder, class: "delete remove-document"


Metrics/LineLength: Line is too long. [167/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:26:48Z

app/controllers/admin/stats_controller.rb


-    @user_count_by_district = User.where.not(balloted_heading_id: nil).group(:balloted_heading_id).count.collect {|k,v| [Budget::Heading.find(k).name, v]}.sort
+    @user_count_by_district = User.where.not(balloted_heading_id: nil).group(:balloted_heading_id).count.collect { |k, v| [Budget::Heading.find(k).name, v] }.sort


Metrics/LineLength: Line is too long. [162/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:26:48Z

app/controllers/admin/stats_controller.rb


    @vote_count = @budget.lines.count

-    @vote_count_by_heading = @budget.lines.group(:heading_id).count.collect {|k,v| [Budget::Heading.find(k).name, v]}.sort
+    @vote_count_by_heading = @budget.lines.group(:heading_id).count.collect { |k, v| [Budget::Heading.find(k).name, v] }.sort


Metrics/LineLength: Line is too long. [125/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:26:49Z

app/controllers/users/registrations_controller.rb

    else
-      render json: {available: true, message: t("devise_views.users.registrations.new.username_is_available")}
+      render json: { available: true, message: t("devise_views.users.registrations.new.username_is_available") }


Metrics/LineLength: Line is too long. [112/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:26:49Z

app/controllers/users/registrations_controller.rb

@@ -50,9 +50,9 @@ def do_finish_signup

  def check_username
    if User.find_by username: params[:username]
-      render json: {available: false, message: t("devise_views.users.registrations.new.username_is_not_available")}
+      render json: { available: false, message: t("devise_views.users.registrations.new.username_is_not_available") }


Metrics/LineLength: Line is too long. [117/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:39:19Z

spec/shared/features/mappable.rb

-                               mappable_show_path,
-                               mappable_path_arguments,
-                               management = false|
+shared_examples "mappable" do |mappable_factory_name, mappable_association_name, mappable_new_path, mappable_edit_path, mappable_show_path, mappable_path_arguments, management = false|


Metrics/LineLength: Line is too long. [184/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:39:19Z

spec/shared/features/nested_documentable.rb

-                                          path, documentable_path_arguments,
-                                          fill_resource_method_name, submit_button,
-                                          documentable_success_notice|
+shared_examples "nested documentable" do |login_as_name, documentable_factory_name, path, documentable_path_arguments, fill_resource_method_name, submit_button, documentable_success_notice|


Metrics/LineLength: Line is too long. [189/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-07-05T01:39:19Z

spec/shared/features/nested_imageable.rb

-                                       imageable_path_arguments, fill_resource_method_name,
-                                       submit_button, imageable_success_notice,
-                                       has_many_images = false|
+shared_examples "nested imageable" do |imageable_factory_name, path, imageable_path_arguments, fill_resource_method_name, submit_button, imageable_success_notice, has_many_images = false|


Metrics/LineLength: Line is too long. [187/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot

Some files could not be reviewed due to errors:

warning: parser/current is loading parser/ruby26, which recognizes

warning: parser/current is loading parser/ruby26, which recognizes warning: 2.6.0-dev-compliant syntax, but you are running 2.6.1. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. 1 error(s) were found in ERB files Linting 1 files with 13 linters...

String not translated: •
In file: app/views/admin/signature_sheets/show.html.erb:6

houndci-bot

Some files could not be reviewed due to errors:

warning: parser/current is loading parser/ruby26, which recognizes

warning: parser/current is loading parser/ruby26, which recognizes warning: 2.6.0-dev-compliant syntax, but you are running 2.6.1. warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri. 1 error(s) were found in ERB files Linting 1 files with 13 linters...

String not translated: •
In file: app/views/admin/signature_sheets/show.html.erb:6

houndci-bot · 2019-08-08T06:37:14Z

spec/shared/models/acts_as_paranoid.rb

@@ -38,7 +38,7 @@
      resource.destroy
      resource.reload

-      expect{ resource.restore(recursive: true) }.to change { resource.translations.with_deleted.first.hidden_at }
+      expect { resource.restore(recursive: true) }.to change { resource.translations.with_deleted.first.hidden_at }


Metrics/LineLength: Line is too long. [115/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-08-08T06:37:14Z

app/views/admin/legislation/draft_versions/_form.html.erb

@@ -1,6 +1,6 @@
 <%= render "shared/globalize_locales", resource: @draft_version %>

-<%= translatable_form_for [:admin, @process, @draft_version], url: url, html: {data: {watch_changes: true}} do |f| %>
+<%= translatable_form_for [:admin, @process, @draft_version], url: url, html: { data: { watch_changes: true }} do |f| %>


Layout/SpaceInsideHashLiteralBraces: Space inside } missing.

houndci-bot · 2019-08-08T06:37:15Z

app/models/signature_sheet.rb

@@ -35,7 +35,7 @@ def verify_signatures
  end

  def parsed_required_fields_to_verify_groups
-    required_fields_to_verify.split(/[;]/).collect {|d| d.gsub(/\s+/, "") }.map { |group| group.split(/[,]/)}
+    required_fields_to_verify.split(/[;]/).collect { |d| d.gsub(/\s+/, "") }.map { |group| group.split(/[,]/) }


Metrics/LineLength: Line is too long. [111/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

houndci-bot · 2019-08-08T06:37:15Z

app/models/concerns/globalizable.rb

    end

    if self.paranoid? && translation_class.attribute_names.include?("hidden_at")
      translation_class.send :acts_as_paranoid, column: :hidden_at
    end

-    scope :with_translation, -> { joins("LEFT OUTER JOIN #{translations_table_name} ON #{table_name}.id = #{translations_table_name}.#{reflections["translations"].foreign_key} AND #{translations_table_name}.locale='#{I18n.locale }'") }
+    scope :with_translation, -> { joins("LEFT OUTER JOIN #{translations_table_name} ON #{table_name}.id = #{translations_table_name}.#{reflections["translations"].foreign_key} AND #{translations_table_name}.locale='#{I18n.locale}'") }


Metrics/LineLength: Line is too long. [234/110] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)

We were following these rules in most places; we just didn't define them anywhere.

Add rubocop spacing rules

houndci-bot reviewed Jun 23, 2019

View reviewed changes

javierm mentioned this pull request Jun 24, 2019

Change basic rubocop rules #3636

Merged

javierm self-assigned this Jun 24, 2019

voodoorai2000 approved these changes Jun 24, 2019

View reviewed changes

javierm force-pushed the rubocop_rules branch from 0a773be to c5d1f61 Compare July 5, 2019 00:20

javierm force-pushed the add_spacing_rules branch from caa769b to 92d44c4 Compare July 5, 2019 00:20