Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change basic rubocop rules #3636

Merged
merged 13 commits into from
Sep 10, 2019
Merged

Change basic rubocop rules #3636

merged 13 commits into from
Sep 10, 2019

Commits on Sep 10, 2019

  1. Apply Rails/PluralizationGrammar rubocop rule

    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    adc5906 View commit details
    Browse the repository at this point in the history

  2. Apply Rails/Presence rubocop rule

    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    a5ba13b View commit details
    Browse the repository at this point in the history

  3. Apply Rails/RequestReferer rubocop rule

    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    daa86ca View commit details
    Browse the repository at this point in the history

  4. Apply Rails/SafeNavigation rubocop rule

    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    9fe8c47 View commit details
    Browse the repository at this point in the history

  5. Configure Rails/UnknownEnv rubocop rule 

    We use staging and preproduction environments, which are not valid by
default.

This rule is useful because misspelling the name of an environment might
otherwise go unnoticed.
    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    27c73c2 View commit details
    Browse the repository at this point in the history

  6. Apply Rails/Validation rubocop rule

    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    0788925 View commit details
    Browse the repository at this point in the history

  7. Apply RSpec/ExampleWording rubocop rule

    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    58ba517 View commit details
    Browse the repository at this point in the history

  8. Apply Rspec/LetSetup rubocop rule

    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    044eabd View commit details
    Browse the repository at this point in the history

  9. Apply RSpec/RepeatedExample rubocop rule

    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    969a4e2 View commit details
    Browse the repository at this point in the history

  10. Apply Capybara/CurrentPathExpectation rubocop rule

    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    c05b9c2 View commit details
    Browse the repository at this point in the history

  11. Apply Bundler rubocop rules 

    We're not using the InsecureProtocolSource rule because I don't feel
it's necessary.
    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    9541ce8 View commit details
    Browse the repository at this point in the history

  12. Apply RSpec/HookArgument rubocop rule

    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    59e107e View commit details
    Browse the repository at this point in the history

  13. Move basic RSpec rubocop rules to basic cops 

    These are rules we were already applying.

We've excluded the `factories` folder for some rules because there's a
factory defining a `context` attribute, which rubocop thought was the
`context` RSpec keyword.
    @javierm
    javierm committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    2243809 View commit details
    Browse the repository at this point in the history