Fix flaky spec: Proposals Search Reorder results maintaing search #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microweb10
approved these changes
Jun 26, 2019
javierm
force-pushed
the
fix_flaky_proposals_spec
branch
from
d1eec8c
to
cd7c38b
Compare
When clicking the button "Search", the link "newest" is already present, so capybara might click the "newest" link before the "Search" request is finished, leading to unexpected results. Checking the page to make sure the "Search" request has finished before clicking the "newest" link solves the problem.
javierm
force-pushed
the
fix_flaky_proposals_spec
branch
from
cd7c38b
to
57bda00
Compare
|
Travis failure is not related to this pull request and will be fixed by #3661. |
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
…ls_spec Fix flaky spec: Proposals Search Reorder results maintaing search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
spec/features/proposals_spec.rb:1449: Proposals Search Reorder results maintaing searchWhy was the spec failing?
When clicking the button "Search", the link "newest" is already present, so capybara might click the "newest" link before the "Search" request is finished, leading to unexpected results.
Checking the page to make sure the "Search" request has finished before clicking the "newest" link solves the problem.