Add puma configuration to version control #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 12, 2019
javierm
force-pushed
the
puma_rb
branch
2 times, most recently
from
a6b9f94
to
a98a7f3
Compare
These files are only loaded when the stage already has the value set inside them, so we don't need to set it again. On the other hand, the `rails_env` setting is configured in the `config/deploy.rb` file.
Deploy environment files were loaded after config/deploy.rb was loaded, meaning if we used settings like `deploy_to` or `current_path` to set variables inside the config/deploy.rb file, we'd be using the default settings instead of the ones dictated by the deploy environment files.
microweb10
approved these changes
Nov 13, 2019
javierm
force-pushed
the
puma_rb
branch
2 times, most recently
from
765c138
to
dd76f41
Compare
We were using Capistrano's shared folder because it was the default folder used by the capistrano-puma gem. However, it's easier to manage it if it's under version control. So we're moving the old `puma.rb` to `puma/development.rb`, and we use the new `puma.rb` file for all environments except development. Anyone installing CONSUL can change these files at will or change the specific files for preproduction, production and staging environments.
smarques
pushed a commit
to venetochevogliamo/consul
that referenced
this pull request
Apr 29, 2020
Add puma configuration to version control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives