Deactivate ckeditor file attachments feature #3976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
reviewed
Apr 17, 2020
This feature was not working so its better to disable it completely. By removing attachment_files endpoints related buttons and tabs from ckeditor UI are not shown to users anymore.
Senen
force-pushed
the
deactivate-ckeditor-file-attachment
branch
from
240a0c5
to
7466148
Compare
javierm
approved these changes
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
By working on #3659 i realized about this error.
Objectives
This feature was not working because it was not fully configured and tested so its better to disable it completely.
Visual Changes
Before
After
Now ckeditor buttons related to file uploads are not shown anymore.
Notes