Update translations from Crowdin #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Senen
force-pushed
the
i18n_crowdin
branch
5 times, most recently
from
92ea6fa
to
33eebaa
Compare
javierm
reviewed
Sep 9, 2020
javierm
approved these changes
Sep 15, 2020
Following locales are now available by default: * "bg" (Bulgarian): 98,5% translated * "ca" (Catalan): 100 % translated * "es-PE" (Spanish from Perú): 64,8% translated * "eu" (Euskara): 67,8% translated * "ka" (Georgian): 98,9% translated * "oc" (Occitan): 98,9% translated * "ro" (Romanian): 99,1% translated Spanish and Euskara were enabled becuase both are near the 70% and its fallback language (Spanish) is complete. Add custom fallbacks: * Catalan (ca) => Español (es). * Español de Perú (es-PE) => Español (es). * Euskara (eu) => Español (es). * Portuguese-Brazilero (pt-BR) => Español (es). * Occitan (oc) => French (fr)
I realized Crowdin suddenly started to change Portuguese-Brazilero locale codes so i asked for Crowdin support and they fixed the problem by configuring an internal post-processor for this project so the reason seems to be some change on the Crowdin side. I tested it successfully by making a dummy update on one translation to see if next commits for this language will come with the right locale ... and it worked nice!
Consul uses two variants of Serbian: Serbian (Cirylic), and Serbian (Latin) so wee need to use different locale codes for each of them to avoid collisions. The folder names of both languages were correct but the locale code within the files was the same for both languages "sr" so translations were mixed. This commit changes the locale code within Serbian (Latin) translations files to "sr-CS", also adds a new language mapping to the Crowdin config file so next ConsulBot commits with Serbian (Latin) translations will be done using the locale code defined at new language mapping.
Crowdin is sending Norwegian (Norway) translations to `config/locales/nn` folder using the `nn`locale code inside files and we do not have any other Norwegian dialect active at Crowdin application so those files seem to not to be needed.
javierm
approved these changes
Sep 15, 2020
This was referenced Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This PR replaces #3944 and solves #4120.
Objectives
Update translations from Crowdin and enable languages with higher translation ratio:
Following languages are now available by default:
Also add custom fallbacks for the some of them:
Other languages (Bulgarian, Georgian, Romanian and Serbian (Cirylic)) will have the default fallback language: English (en).
Remove the duplicated files for Norwegian (Norway) language, we only kept the ones using
nnas locale code inside files and as language translations directory. Crowdin is sending Norwegian (Norway) translations usingnn.This PR also enables the Serbian (Cirylic) language because it has a very high translation but Crowdin is sending Serbian (Latin) translations with the same locale code
srthat is using for Serbian (Cyrillic) language (which is not enabled yet because its current low translation ratio). To solve this we updated all Serbian (Latin) locale codes fromsrtosr-CSmanually and added a new language mapping at the crowdin.yml configuration file so Serbian (Latin) translation will come usingsr-CSlocale code.Crowdin post-processors
Recently Crowdin integration xtarted to change Portuguese-Brazileiro locale code from
pt-BRtopt, this was due to some internal change at Crowdin platform. As this would break the Portuguese Brazileiro translations i asked for Crowdin support and they enabled an internal post-processor to avoid this change.I think that this might be configurable from Crowdin settings or via the
crowdin.ymlfile we have, but this seems to be a setting only available on request to the Crowdin support service. This might a little bit confusing for developers as they cannot see this kind of setting nowhere within our codebase.Comparison with previous release status (1.1.0)
Here is a comparison table between translation status of latest release 1.1.0 and this branch (i18n_crowdin).
Note: Ratios in the table above were calculated considering the amount of keys translated so that percentages will not match the percentages shown at Crowding project homepage where the calculation considers the amount of translated words instead of the amount of translated keys.
As you can see at table above some languages (23) translation ratio decreased compared to previous Consul release 1.1.0 but we can consider the decrease small, the biggest translation ratio decrease is about of 1% so there is nothing to worry about, this decrease is due to changes at source strings or new ones added in work done from 1.1.0 release date. This can be fixed by the translators of each language by adding/updating translations for new/updated source strings.
The same happens with new inconsistent interpolations ... it can be fixed by the translators through Crowding application.