Update translations from Crowdin #4140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add translations files for two new languages: Indonesian and Tagalog. Change Serbian (Cyrillic) folder from `sr-SP` to `sr`, this is a preference of us so we can run i18n-tasks without having to rename the folder first.
javierm
approved these changes
Sep 23, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This PR replaces #4132
Objectives
Add the latest translations since the last update of Crowdin #4121.
Add translations files for two new languages: Indonesian and Tagalog.
Change Serbian (Cyrillic) folder from
sr-SPtosr, this is a preference of us so we can runi18n-taskswithout having torename the folder first. To be able to run
i18n-tasksgem for any language the locale folder name has to match the locale code within the translation files so the gem can calculate right results. If folder name and locale code does not matchi18n-tasksgem will not be able to find any translation so results will not be true. As example: For Serbian (Latin) languagei18n-taskswill work when the path to the translation filesconfig/locales/sr-CS/*and the locale code within this folder files are alsosr-CS.Notes
A post-processor was finally needed from the Crowdin side to avoid conflicts between Serbian (Cryrillic) and Serbian (Latin) translations. It would be nice if this could be configurable from
crowdin.ymlfile 馃槥 .