-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump factory_bot_rails from 4.8.2 to 6.1.0 #4185
Bump factory_bot_rails from 4.8.2 to 6.1.0 #4185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update breaks our current code; we need to update our factories before updating this gem.
@dependabot rebase |
1499893
to
c5b883c
Compare
Bumps [factory_bot_rails](https://github.com/thoughtbot/factory_bot_rails) from 4.8.2 to 6.1.0. - [Release notes](https://github.com/thoughtbot/factory_bot_rails/releases) - [Changelog](https://github.com/thoughtbot/factory_bot_rails/blob/master/NEWS.md) - [Commits](thoughtbot/factory_bot_rails@v4.8.2...v6.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
TODO: paranoia, database consistency, new associations, deleted users, :dependent option. Some records are not going to be orphaned because they're destroyed when their associated record is destroyed: * Images are destroyed when their imageable is destroyed * Follows are destroyed when their followable is destroyed * Milestones are destroyed when their milestoneable is destroyed * Headings are destroyed when their group is destroyed * Groups are destroyed when their budget is destroyed * Related contents are destroyed whent their parent is destroyed And some records won't be orphaned because their association cannot be destroyed: * Polls cannot be destroyed if there are voters * Headings cannot be deleted if there are investments
This was the default in Factory Bot 4.x and changed in Factory Bot 5.
a2cfd6d
to
851799f
Compare
This pull request will no longer be automatically closed when a new version is found as this pull request was created by Dependabot Preview and this repo is using a |
Closing in favor of #4607. |
Bumps factory_bot_rails from 4.8.2 to 6.1.0.
Release notes
Sourced from factory_bot_rails's releases.
Changelog
Sourced from factory_bot_rails's changelog.
Commits
3564a68
Bump version to v.6.1.0 [ci skip]4b39c91
Bump version to v.6.1.0 [ci skip]956beb1
Bump all dev dependencies6a707ad
Remove Hound badge [ci skip]8f17a63
Bump version to v6.0.0 [ci skip]bfee5d8
Set up reloading after_initialize870bf2a
Run standard on CIce8bfb4
Run standardrbaad77ce
Replace Rubocop with standarda80044c
Bump all dev dependenciesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Note: This repo was added to Dependabot recently, so you'll receive a maximum of 25 PRs for your first few update runs. Once an update run creates fewer than 25 PRs we'll remove that limit.
You can always request more updates by clicking
Bump now
in your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: