Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump factory_bot_rails from 4.8.2 to 6.1.0 #4185

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Sep 28, 2020

Bumps factory_bot_rails from 4.8.2 to 6.1.0.

Release notes

Sourced from factory_bot_rails's releases.

v6.1.0

  • Changed: factory_bot dependency to ~> 6.1.0

v6.0.0

  • Fixed: generate a plural factory name when the --force-plural flag is provided
  • Changed: factory_bot dependency to ~> 6.0.0
  • Removed: "factory_bot.register_reloader" initializer, now registering the reloader after application initialization
  • Removed: support for EOL versions of Ruby (2.3, 2.4) and Rails (4.2)

v5.2.0

  • Changed: factory_bot dependency to ~> 5.2.0

v5.1.1

  • Fixed: Ensure definitions do not load before I18n is initialized

v5.1.0

Changed: factory_bot dependency to ~> 5.1.0

v5.0.2

  • Bugfix: Reload factory_bot whenever the application changes to avoid holding onto stale object references
  • Bugfix: Avoid watching project root when no factory definitions exist

v5.0.1

Bugfix: Avoid watching files and directories that don't exist (to avoid a file watching bug in Rails rails/rails#32700). Thanks to @y-yagi for this fix!

v5.0.0

  • Added: calling reload! in the Rails console will reload any factory definition files that have changed
  • Added: support for custom generator templates
  • Added: definition_file_paths configuration option, making it easier to place factories in custom locations
  • Changed: namespaced models are now generated inside a directory matching the namespace
  • Changed: added newline between factories generated into the same file
  • Removed: support for EOL version of Ruby and Rails

v5.0.0.rc2

No release notes provided.

v5.0.0.rc1

  • Added: calling reload! in the Rails console will reload any factory definition files that have changed
  • Added: support for custom generator templates
  • Added: definition_file_paths configuration option, making it easier to place factories in custom locations
  • Changed: namespaced models are now generated inside a directory matching the namespace
  • Changed: added newline between factories generated into the same file
  • Removed: support for EOL version of Ruby and Rails

v4.11.1

Update generator to use dynamic attributes instead of deprecated static attributes

v4.11.0

Changelog

Sourced from factory_bot_rails's changelog.

6.1.0 (July 8, 2020)

  • Changed: factory_bot dependency to ~> 6.1.0

6.0.0 (June 18, 2020)

  • Fixed: generate a plural factory name when the --force-plural flag is provided
  • Changed: factory_bot dependency to ~> 6.0.0
  • Removed: "factory_bot.register_reloader" initializer, now registering the reloader after application initialization
  • Removed: support for EOL versions of Ruby (2.3, 2.4) and Rails (4.2)

5.2.0 (April 26, 2020)

  • Changed: factory_bot dependency to ~> 5.2.0

5.1.1 (September 24, 2019)

  • Fixed: Ensure definitions do not load before I18n is initialized

5.1.0 (September 24, 2019)

  • Changed: factory_bot dependency to ~> 5.1.0

5.0.2 (April 14, 2019)

  • Bugfix: Reload factory_bot whenever the application changes to avoid holding onto stale object references
  • Bugfix: Avoid watching project root when no factory definitions exist

5.0.1 (February 9, 2019)

  • Bugfix: Avoid watching files and directories that don't exist (to avoid a file watching bug in Rails rails/rails#32700)

5.0.0 (February 1, 2019)

  • Added: calling reload! in the Rails console will reload any factory definition files that have changed
  • Added: support for custom generator templates
  • Added: definition_file_paths configuration option, making it easier to place factories in custom locations
  • Changed: namespaced models are now generated inside a directory matching the namespace
  • Changed: added newline between factories generated into the same file
  • Removed: support for EOL version of Ruby and Rails

4.11.1 (September 7, 2018)

  • Update generator to use dynamic attributes instead of deprecated static attributes

4.11.0 (August 16, 2018)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 25 PRs for your first few update runs. Once an update run creates fewer than 25 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that updates a dependency label Sep 28, 2020
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update breaks our current code; we need to update our factories before updating this gem.

@javierm
Copy link
Member

javierm commented Oct 2, 2020

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/factory_bot_rails-6.1.0 branch from 1499893 to c5b883c Compare October 2, 2020 17:00
@javierm javierm self-assigned this Oct 2, 2020
dependabot-preview bot and others added 3 commits October 4, 2020 12:26
TODO: paranoia, database consistency, new associations, deleted users,
:dependent option.

Some records are not going to be orphaned because they're destroyed when
their associated record is destroyed:

* Images are destroyed when their imageable is destroyed
* Follows are destroyed when their followable is destroyed
* Milestones are destroyed when their milestoneable is destroyed
* Headings are destroyed when their group is destroyed
* Groups are destroyed when their budget is destroyed
* Related contents are destroyed whent their parent is destroyed

And some records won't be orphaned because their association cannot be
destroyed:

* Polls cannot be destroyed if there are voters
* Headings cannot be deleted if there are investments
This was the default in Factory Bot 4.x and changed in Factory Bot 5.
@javierm javierm force-pushed the dependabot/bundler/factory_bot_rails-6.1.0 branch from a2cfd6d to 851799f Compare October 4, 2020 11:52
@dependabot-preview
Copy link
Contributor Author

This pull request will no longer be automatically closed when a new version is found as this pull request was created by Dependabot Preview and this repo is using a version: 2 config file. You can close this pull request and let Dependabot re-create it the next time it checks for updates.

@javierm
Copy link
Member

javierm commented Aug 11, 2021

Closing in favor of #4607.

@javierm javierm closed this Aug 11, 2021
@javierm javierm deleted the dependabot/bundler/factory_bot_rails-6.1.0 branch August 11, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant