Avoid exceptions in Management section #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taitus
force-pushed
the
improve-management
branch
from
513311a
to
abf7954
Compare
Senen
approved these changes
Apr 6, 2021
taitus
force-pushed
the
improve-management
branch
from
abf7954
to
06470a2
Compare
taitus
force-pushed
the
improve-management
branch
4 times, most recently
from
0330f8c
to
e7cdd40
Compare
javierm
reviewed
Apr 7, 2021
taitus
force-pushed
the
improve-management
branch
from
e7cdd40
to
85c0797
Compare
We prepare the file to be able to include specs that do not need to have a logged-in user. We also took the opportunity to not execute this line in some specs where it was not necessary.
taitus
force-pushed
the
improve-management
branch
from
85c0797
to
0e05255
Compare
Many management actions only make sense if a user has been selected beforehand. We updated :check_verified_user method to be able to check actions that need to have a user selected in order to avoid exceptions. We need this control as :only_verified_user is not restrictive enough. The reason is that the :managed_user method used in the :only_verified_user if it does not find a user it does an initializce (find_or_initialize_by). This causes that when we have "skip_verification" to true, it returns this non-persisted user as "verified". These changes affect the actions of Account, Budgets and Proposals Controller when no user is selected.
javierm
force-pushed
the
improve-management
branch
from
0e05255
to
e213814
Compare
|
The test which failed is not related to this pull request and will be fixed by #4467. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Closes #2767
Objectives
Many management actions only make sense if a user has been selected beforehand.
The objective is only allow management actions when we have a selected user.
Notes
I was unable to reproduce the error in the related issue (#2767) with the steps above.
But I have detected a bug related and even partially commented on in some comments of that issue.