Fix flaky spec "Notifications User not logged in" #4467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
fix_flaky_notification_spec
branch
from
5cd39ad
to
0f1fa51
Compare
javierm
force-pushed
the
fix_flaky_notification_spec
branch
2 times, most recently
from
05fad2b
to
b37872a
Compare
We had a test failing several times in GitHub Actions where a user was still logged in even after logout. This issue can be reproduced running: ``` rspec spec/system/moderation/proposal_notifications_spec.rb:71 \ spec/system/notifications_spec.rb:126 --order defined ``` One possible cause is a concurrency issue because the process running the test and the process running the browser both access the same database connection. Maybe some database operations leak between tests due to that, particularly if the previous test accessed the database after starting the browser as well. A way to avoid this possible cause is setting up the database before starting the browser with a call to `visit`.
javierm
force-pushed
the
fix_flaky_notification_spec
branch
from
b37872a
to
b9da024
Compare
Senen
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
This issue can be reproduced running
rspec spec/system/moderation/proposal_notifications_spec.rb:71 spec/system/notifications_spec.rb:126 --order defined.We had a test failing several times in GitHub Actions where a user was still logged in even after logout.
One possible cause is a concurrency issue because the process running the test and the process running the browser both access the same database connection. Maybe some database operations leak between tests due to that.
Objectives