-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dalli from 2.7.10 to 2.7.11 #4636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
requested changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this pull request introduces a deprecation warning and Rails 5.2 introduces (optionally) a new cache versioning system, we'll have a closer look before merging.
dependabot
bot
force-pushed
the
dependabot/bundler/master/dalli-2.7.11
branch
from
August 13, 2021 00:48
9084c0a
to
a5dae5a
Compare
@dependabot rebase |
Bumps [dalli](https://github.com/petergoldstein/dalli) from 2.7.10 to 2.7.11. - [Release notes](https://github.com/petergoldstein/dalli/releases) - [Changelog](https://github.com/petergoldstein/dalli/blob/master/History.md) - [Commits](petergoldstein/dalli@v2.7.10...v2.7.11) --- updated-dependencies: - dependency-name: dalli dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/bundler/master/dalli-2.7.11
branch
from
August 14, 2021 23:54
a5dae5a
to
1d594d1
Compare
javierm
force-pushed
the
dependabot/bundler/master/dalli-2.7.11
branch
2 times, most recently
from
August 15, 2021 17:28
8c4e08a
to
331aee8
Compare
javierm
approved these changes
Aug 15, 2021
`dalli_store` is deprecated since dalli 2.7.11. We can now enable cache_versioning. We didn't enable it when upgrading to Rails 5.2 because of possible incompatibility with `dalli_store` [1], even though apparently some the issues were fixed in dalli 2.7.9 and dalli 2.7.10 [2]. Since using cache versioning makes cache expiration more efficient, and I'm not sure whether the options we were passing to the dalli store are valid with memcache store (documentation here is a bit lacking), I'm just removing the option we used to double the default cache size on production. [1] https://www.schneems.com/2018/10/17/cache-invalidation-complexity-rails-52-and-dalli-cache-store [2] https://github.com/petergoldstein/dalli/blob/master/History.md
javierm
force-pushed
the
dependabot/bundler/master/dalli-2.7.11
branch
from
August 15, 2021 17:43
331aee8
to
e01a94d
Compare
javierm
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps dalli from 2.7.10 to 2.7.11.
Changelog
Sourced from dalli's changelog.
Commits
f82b9e1
Deprecate dalli_store2b40485
need rails to run tests!e7a28ae
fix build?f8b344a
fix build06d1218
Only test modern Rubiesfeae88d
remove pointless badges1cb5b3a
Move gemspec dev deps into Gemfile9c6c6a2
readme update004209e
Remove old unused stuffcd24d9c
Update appraisalsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)