Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dalli from 2.7.10 to 2.7.11 #4636

Merged
merged 2 commits into from
Aug 15, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 11, 2021

Bumps dalli from 2.7.10 to 2.7.11.

Changelog

Sourced from dalli's changelog.

2.7.11

  • DEPRECATION: :dalli_store will be removed in Dalli 3.0. Use Rails' official :mem_cache_store instead. https://guides.rubyonrails.org/caching_with_rails.html
  • Add new digest_class option to Dalli::Client #724
  • Don't treat NameError as a network error #728
  • Handle nested comma separated server strings (sambostock)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that updates a dependency label Aug 11, 2021
Copy link
Member

@javierm javierm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this pull request introduces a deprecation warning and Rails 5.2 introduces (optionally) a new cache versioning system, we'll have a closer look before merging.

@dependabot dependabot bot force-pushed the dependabot/bundler/master/dalli-2.7.11 branch from 9084c0a to a5dae5a Compare August 13, 2021 00:48
@javierm
Copy link
Member

javierm commented Aug 14, 2021

@dependabot rebase

Bumps [dalli](https://github.com/petergoldstein/dalli) from 2.7.10 to 2.7.11.
- [Release notes](https://github.com/petergoldstein/dalli/releases)
- [Changelog](https://github.com/petergoldstein/dalli/blob/master/History.md)
- [Commits](petergoldstein/dalli@v2.7.10...v2.7.11)

---
updated-dependencies:
- dependency-name: dalli
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/master/dalli-2.7.11 branch from a5dae5a to 1d594d1 Compare August 14, 2021 23:54
@javierm javierm force-pushed the dependabot/bundler/master/dalli-2.7.11 branch 2 times, most recently from 8c4e08a to 331aee8 Compare August 15, 2021 17:28
`dalli_store` is deprecated since dalli 2.7.11.

We can now enable cache_versioning. We didn't enable it when upgrading
to Rails 5.2 because of possible incompatibility with `dalli_store` [1],
even though apparently some the issues were fixed in dalli 2.7.9 and
dalli 2.7.10 [2].

Since using cache versioning makes cache expiration more efficient, and
I'm not sure whether the options we were passing to the dalli store are
valid with memcache store (documentation here is a bit lacking), I'm
just removing the option we used to double the default cache size on
production.

[1] https://www.schneems.com/2018/10/17/cache-invalidation-complexity-rails-52-and-dalli-cache-store
[2] https://github.com/petergoldstein/dalli/blob/master/History.md
@javierm javierm force-pushed the dependabot/bundler/master/dalli-2.7.11 branch from 331aee8 to e01a94d Compare August 15, 2021 17:43
@javierm javierm merged commit 0ee0388 into master Aug 15, 2021
@javierm javierm deleted the dependabot/bundler/master/dalli-2.7.11 branch August 15, 2021 18:02
@javierm javierm self-assigned this Aug 16, 2021
@javierm javierm added this to Reviewing in Consul Democracy via automation Aug 16, 2021
@javierm javierm moved this from Reviewing to Release 1.4.0 in Consul Democracy Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant