Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify navigation in single heading budgets #4718

Merged
merged 4 commits into from
Nov 3, 2021
Merged

Simplify navigation in single heading budgets #4718

merged 4 commits into from
Nov 3, 2021

Conversation

javierm
Copy link
Member

@javierm javierm commented Oct 23, 2021 •
edited
Loading

References

Objectives

  • Go directly to the investments page when clicking on a single heading group
  • Show ballot during the voting phase after clicking the "See all investments" link in single heading budgets

@javierm javierm self-assigned this Oct 23, 2021
@javierm javierm changed the base branch from master to investment_filters_selector October 23, 2021 22:37
@javierm javierm force-pushed the investment_filters_selector branch 6 times, most recently from bcb9bdd to 0bdec42 Compare October 26, 2021 15:02
@javierm javierm force-pushed the single_heading_links branch 2 times, most recently from 91dd104 to cc63ffb Compare October 26, 2021 15:48
@javierm javierm force-pushed the investment_filters_selector branch 3 times, most recently from f46e384 to 756a16f Compare October 29, 2021 13:02
Base automatically changed from investment_filters_selector to master October 29, 2021 13:22
@javierm
Move ballot partial to a component
4243de3 
This way it'll be easier to extract methods from its code and modify
them.
@javierm
Extract methods in ballot component
9f94e95 
Assigning variables in the view makes the code harder to read.
@javierm
Go to investments list from a single heading group
f669b47 
There's no real point in linking to a page offering users to choose a
heading when there's only one heading to choose.

So we're linking to the investments index instead.
@javierm
Fix investments link in single heading budgets
caebaac 
The link to "See all investments" didn't have the `heading_id`
parameter, which resulted in the ballot information not being displayed
when in the voting phase.

We could modify the link to include the `heading_id` parameter, but IMHO
it's more robust to select the heading automatically when there's only
one heading. That way manually accessing the page without a `heading_id`
parameter will still work as if the heading had been selected.
@taitus taitus self-assigned this Nov 3, 2021
@javierm javierm merged commit 9e1f28e into master Nov 3, 2021
@javierm javierm deleted the single_heading_links branch November 3, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taitus taitus taitus approved these changes

Assignees

@taitus taitus

@javierm javierm

Labels
Budgets UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javierm @taitus