Avoid mousewheel/finger trap in the map #4768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Senen
force-pushed
the
map-pan-control
branch
2 times, most recently
from
0e460bb
to
0e01219
Compare
Solve a usability issue when a user's scrolls on pages with a map and additional content below. When the user is scrolling, and the mouse goes over the map, the window stops scrolling, and the map starts moving; this behaviour annoys the users as they expect to keep scrolling the page to the bottom. A similar problem occurs when browsing the page on touchable devices like phones or tablets. We are disabling the mouse wheel map listener to keep scrolling to the page bottom on desktop devices. We are disabling the dragging and the tap features for mobile devices, although as the user can not move the map, we need arrow controls to allow users to change the map pan. Credits for the mobile solution are for SimonEast [1]. [1] Check Github Leaflet/leaflet project issue 5425#issuecomment-342055520.
Code extracted from: https://github.com/kartena/Leaflet.Pancontrol
We needed to adapt the original code so it works with the Rails asset pipeline.
We only need the new controls for the mobile version as it is impossible to move map panes after disabling `dragging` and `tap` options. In contrast, desktop users can drag the map by clicking and dragging the mouse. However, I finally decided to show the pan controls for desktop and mobile devices to keep consistency and considering that some users can browse the website through both kind on devices.
Using a fixed offset for all screen sizes does not work nice. For example, when using mobile devices (usually small), the default offset value (500px by default) moves the map pan to a too far pan and makes the user lose the reference point from the previous pan. Using the same offset for the vertical and horizontal pan controls does not work nicely when the map does not have an square shape. To better control the vertical and horizontal offsets and considering we show maps with all the shapes, we will use different offsets for vertical and horizontal panning calculated from the map dimensions, so we can move the pan as much as possible without losing the reference point.
Senen
force-pushed
the
map-pan-control
branch
from
0e01219
to
195479b
Compare
|
Closing in favor of #5096. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This fixes usability issues when scrolling pages with a map and more content below. card-74165431
Objectives
Make it easier for users to scroll the page to the bottom by:
Visual Changes
Before
After
Notes
Alternative solutions
The first solution I tried was to install a Leaflet plugin that adds a similar behaviour to Google Maps Gesture Handling plugin. During mobile testing, I found it works nicely in Chrome, Edge, Opera and Safari, while the user experience when using two fingers to move or zoom the map is annoying in Firefox. Unfortunately, it seems to conflict in some way with the page scroll, so I finally chose to use controls to allow users to move the map. Here is a work in progress branch with the Leatflet.GestureHandling plugin installed in CONSUL.