Bump Leaflet from 1.5.1 to 1.9.3 #5096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
javierm
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Dind't know about the scrollWheelZoom: false. Great! 🎉
I thought that change was related to changing the gem dependency, but I see that's not the case 🤔. What would do you think about keeping the commit "Disable scroll wheel for zooming in favor of map zoom buttons" (since it also works with the master branch) and then opening a new pull request with the gem change to replace #4970?
Senen
changed the title
javierm
force-pushed
the
ruby3.0
branch
2 times, most recently
from
6b8c3a3
to
f298715
Compare
Newer versions have more capabilities and also fix lot of errors, usability and accessibility issues. Note that we're using an external gem to rails-assets.org as it's not supports the rails-assets pipeline. This gems wraps the original one and make the code work with the default rails assets pipeline as usual.
javierm
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Replaces:
Objectives
Newer versions have more capabilities and also fix lot of errors,
usability and accessibility issues.
Note that we're using an external gem to rails-assets.org as it
not supports the rails-assets pipeline. This gems wraps the
original one and make the code work with the default rails assets
pipeline as usual.
Manual testing
Desktop browsers
Verified successfully in the following desktop and mobile browsers:
Visual Changes
None