Show verification info only if verification is enabled #4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, since we're touching this part of the application, I think we'll add some changes to fix an accessibility issue we've got here. We say "With you account you can (...) icon-x Support proposals". But the icon isn't shown for screen readers, so people using them actually hear that they can support proposals when they cannot. |
javierm
force-pushed
the
verification_info
branch
2 times, most recently
from
084fe8f
to
22e3940
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
javierm
force-pushed
the
permission_list_accessibility
branch
from
4861ded
to
608831b
Compare
javierm
force-pushed
the
verification_info
branch
from
fc4a392
to
3607282
Compare
javierm
force-pushed
the
permission_list_accessibility
branch
from
608831b
to
49b319e
Compare
javierm
force-pushed
the
verification_info
branch
from
3607282
to
b3ad121
Compare
javierm
force-pushed
the
permission_list_accessibility
branch
from
49b319e
to
b859cb8
Compare
javierm
force-pushed
the
verification_info
branch
from
b3ad121
to
68be7ec
Compare
javierm
force-pushed
the
permission_list_accessibility
branch
from
b859cb8
to
830501c
Compare
javierm
force-pushed
the
permission_list_accessibility
branch
from
830501c
to
2bac802
Compare
javierm
force-pushed
the
verification_info
branch
from
68be7ec
to
3788376
Compare
Senen
reviewed
Jan 4, 2023
| @@ -1270,16 +1266,6 @@ form { | |||
| vertical-align: top; | |||
| } | |||
|
|
|||
| .user-permissions { | |||
There was a problem hiding this comment.
Not a big deal, but what do you think about removing the class user-permissions from the following views?
- app/views/account/show.html.erb
- app/views/management/_user_permissions.html.erb
- app/views/verification/letter/new.html.erb
- app/views/verification/residence/new.html.erb
It seems now that class is useless 🤔
There was a problem hiding this comment.
Interesting! I'd vote for keeping the class, at least for now. There might be people using custom styles for this class, and removing it would make the element harder to style 🤔.
We're also adding tests showing the current behavior, which we're about to change.
It was strange to tell users they need to verify their account in order to perform all available actions when they've already verified their account.
As mentioned in commit 925f04e, icon classes make screen readers announce strange symbols and aren't properly displayed for people who have changed their preferred font family.
The contrast value was 1.75, which makes the text hard to read and it isn't even near to the minimum accessibility requirements. We're using the `$color-success` variable since the `$check` color is green and this one is green too.
Using line-height is confusing and has unexpected results when texts span over multiple lines, as might be the case in some language and screen resolution combinations.
javierm
force-pushed
the
verification_info
branch
from
3788376
to
f138709
Compare
Senen
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Now, even if the "Skip user verification" setting is enabled at
admin/settings#tab-feature-flagson the "My account"/accountpage the text "To perform all the actions verify your account. / Account verified" is displayed which can be a bit confusing for users.This PR hides this information if the "Skip user verification" setting is active.
Visual Changes
Before
After