Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tenant host and name as default email sender #5034

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Use tenant host and name as default email sender #5034

merged 2 commits into from
Nov 28, 2022

Commits on Nov 28, 2022

  1. Use current host as default email address domain 

    We were using `consul.dev` as default, which might be fine for the
development environment, but it's something that definitely needs to be
changed on production.

Now we're providing a better default setting: using the same domain
which is used to generate URLs in emails. This also makes it easier to
configure new tenants, since the setting will default to whatever host
the new tenant is using.

The `|| "consul.dev"` part might not be needed; I'm keeping it because
I'm not sure production environents would not experience any new issues
if we don't add it, but we might remove it in the future.
    @javierm
    javierm committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0361432 View commit details
    Browse the repository at this point in the history

  2. Use the tenant name as default organization name 

    This way we'll avoid having all tenant organizations named "CONSUL" by
default, and we'll also use different email senders per tenant, which
will reduce the change of the emails being marked as spam.
    @javierm
    javierm committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    061ae94 View commit details
    Browse the repository at this point in the history