Use tenant host and name as default email sender #5034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
default_mailer_from_address
branch
3 times, most recently
from
5bdfeeb
to
132a004
Compare
javierm
changed the title
javierm
force-pushed
the
default_mailer_from_address
branch
2 times, most recently
from
0690e71
to
1cd217e
Compare
javierm
force-pushed
the
default_mailer_from_address
branch
2 times, most recently
from
b978ca2
to
07a0839
Compare
We were using `consul.dev` as default, which might be fine for the development environment, but it's something that definitely needs to be changed on production. Now we're providing a better default setting: using the same domain which is used to generate URLs in emails. This also makes it easier to configure new tenants, since the setting will default to whatever host the new tenant is using. The `|| "consul.dev"` part might not be needed; I'm keeping it because I'm not sure production environents would not experience any new issues if we don't add it, but we might remove it in the future.
This way we'll avoid having all tenant organizations named "CONSUL" by default, and we'll also use different email senders per tenant, which will reduce the change of the emails being marked as spam.
javierm
force-pushed
the
default_mailer_from_address
branch
from
07a0839
to
061ae94
Compare
taitus
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Background
We were using
consul.devas default, which might be fine for the development environment, but it's something that definitely needs to be changed on production.On these environments, using the same domain which is used to generate URLs in emails is a better default option. This also makes it easier to configure new tenants, since the setting will default to whatever host the new tenant is using.
Objectives