Add expectations in tests confirming account #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -392,6 +392,9 @@ | |||
|
|
|||
| fill_in "Username", with: "manuela2" | |||
| click_button "Register" | |||
|
|
|||
| expect(page).to have_content "To continue, please click on the confirmation link that we have sent you via email" | |||
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [121/110] (https://rubystyle.guide#max-line-length)
javierm
changed the title
javierm
force-pushed
the
confirm_email_expectations
branch
from
ea7516e
to
7f30de0
Compare
One of these tests has failed once because there wasn't a user with the right confirmation token. While I haven't been able to reproduce the issue, there's a chance it's caused by a `visit` call to the confirmation path which might start before the redirect request to the successful sign up page has finished. I'm not sure this is the case, though, but, worst case scenario, if the test fails again we'll know it isn't because of a missing expectation.
javierm
force-pushed
the
confirm_email_expectations
branch
from
7f30de0
to
e68c22b
Compare
taitus
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives