Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky spec in budget supports admin stats #5083

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Fix flaky spec in budget supports admin stats #5083

merged 1 commit into from
Feb 21, 2023

Conversation

taitus
Copy link
Member

@taitus taitus commented Feb 21, 2023 •
edited by javierm
Loading

References

Objectives

  • Fix a flaky spec

@taitus taitus self-assigned this Feb 21, 2023
@taitus taitus mentioned this pull request Feb 21, 2023
Merged
@javierm javierm self-assigned this Feb 21, 2023
@taitus @javierm
Fix flaky spec in budget supports admin stats
1ea5b69 
The test that was not passing sometimes since commit 915999d because
we no longer created the budget before visiting the page that loads it.
So now we're forcing its creation with `let!`.
@javierm javierm changed the title Update specs Fix flaky spec in budget supports admin stats Feb 21, 2023
@javierm javierm merged commit c1d70ef into master Feb 21, 2023
@javierm javierm deleted the fix-specs branch February 21, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierm javierm javierm approved these changes

Assignees

@taitus taitus

@javierm javierm

Labels
Flaky spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taitus @javierm