Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS: Optionally render last sign in info in my account #5274

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

taitus
Copy link
Member

@taitus taitus commented Oct 9, 2023

Objectives

  • Render last sign_in datetime. Showing or not showing it should be configurable.

How

We added a specific security secret to allow display a text with the last access made to the application by the user and to show from which ip, if registered. This information will be displayed in the "My account" page.

Related ENS: "[op.acc.5.r5.2] Se informará al usuario del último acceso efectuado con su identidad."

Sponsored

Functionality developed by

@taitus taitus marked this pull request as ready for review October 9, 2023 09:20
@Senen Senen self-assigned this Oct 19, 2023
In order to comply with the security measure for the
ENS: "[op.acc.5.r5.2] The user shall be informed of
the last access made with his identity".

We have added a new secret to display the last
access made to the user on the "My account" page.
@javierm javierm added the security Pull requests that address a security vulnerability label Oct 24, 2023
@taitus taitus merged commit c1e0d58 into master Oct 24, 2023
14 checks passed
@taitus taitus deleted the last-sign-in branch October 24, 2023 16:57
@javierm javierm changed the title ENS: Add security secret "last_sign_in" ENS: Optionally render last sign in info in my account Nov 22, 2023
@javierm javierm changed the title ENS: Optionally render last sign in info in my account Optionally render last sign in info in my account Nov 22, 2023
@javierm javierm changed the title Optionally render last sign in info in my account ENS: Optionally render last sign in info in my account Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants