Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add issue and PR templates #504

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

andyzhangx
Copy link
Contributor

It's better have a template for issues and PRs, we could refine the templates later.
/assign @jdef @saad-ali

@jdef
Copy link
Member

jdef commented Mar 30, 2022

Thanks for the PR.

The templates seem a bit k8s-centric, and this is not a k8s project. Nor does it use k8s PR robots.

I'm open to the idea of templates, but I think we should probably scrub e.g. links to k8s-specific things.

.github/ISSUE_TEMPLATE/bug-report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/support.md Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@andyzhangx
Copy link
Contributor Author

I have removed the k8s related things, PTAL, thanks.

Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@saad-ali saad-ali merged commit e4c4553 into container-storage-interface:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants