Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IGNORED_TOOLS arg #54

Closed
rarkins opened this issue May 18, 2021 · 4 comments · Fixed by #94
Closed

Support IGNORED_TOOLS arg #54

rarkins opened this issue May 18, 2021 · 4 comments · Fixed by #94
Assignees
@viceice

Comments

@rarkins
Copy link
Member

rarkins commented May 18, 2021

We should support a IGNORED_TOOLS build argument, which will be a comma-separated list. If the list is non-empty, any tool within should be skipped for install-tool.

Example: IGNORED_TOOLS=PIPENV,HELM

Maybe we can make it case-insensitive? e.g. allowing IGNORED_TOOLS=pipenv,helm too.
@viceice
Copy link
Member

viceice commented May 18, 2021

Sure, will make to lowercase before check

@rarkins
Copy link
Member Author

rarkins commented May 18, 2021

Do we have an auto generated list of supported tool names anywhere yet?

@viceice
Copy link
Member

viceice commented May 18, 2021

no, not yet

@viceice viceice mentioned this issue Jul 15, 2021
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viceice viceice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support ignore tools by arg containerbase/base
2 participants
@viceice @rarkins