fix: properly test for installed git-lfs #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you describe, why the old test is not working as expected? |
Because no test existed. I now invoke |
gjasny
force-pushed
the
fix-git-lfs-install
branch
from
297e4ef
to
b54eed5
Compare
gjasny
force-pushed
the
fix-git-lfs-install
branch
from
b54eed5
to
5147bd3
Compare
gjasny
force-pushed
the
fix-git-lfs-install
branch
from
5147bd3
to
b58cb5e
Compare
CI on my branch is green: https://github.com/gjasny/buildpack/actions/runs/1667814918 |
viceice
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test before claimed that
git-lfsis already installed, even if it was not.