vendor: update go.etcd.io/bbolt v1.3.4 #4134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
full diff: etcd-io/bbolt@v1.3.3...v1.3.4 - Fix unsafe pointer conversions caught by Go 1.14 checkptr - Fix unexpected delete bucket error: "delete bucket: incompatible value" - Add support for aix - Add go.mod - db.Path() resolves to db.file.Name() Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Build succeeded.
|
|
@thaJeztah so the plan is to upgrade this package first get a clean run in Go 1.13 and then move to Go 1.14? |
|
@dims partially, yes: IIUC there's more changes needed to make Go 1.14 work (https://twitter.com/_AkihiroSuda_/status/1242567902156357632?s=20), so at least making sure we get changes in that may be needed to update. |
|
@thaJeztah sounds good! watching this space as we have to bump go in k/k as well kubernetes/kubernetes#88638 ( which means we will need to be able to work with bbolt dependency from both contianerd and etcd ) |
AkihiroSuda
approved these changes
Mar 30, 2020
|
LGTM |
This was referenced Apr 3, 2020
AkihiroSuda
added a commit
to AkihiroSuda/containerd
that referenced
this pull request
Jun 22, 2020
We had once updated bbolt from v1.3.3 to v1.3.4 in containerd#4134, but reverted to v1.3.3 in containerd#4156 due to "fatal error: sweep increased allocation count" (etcd-io/bbolt#214). The issue was fixed in bbolt v1.3.5 (etcd-io/bbolt#220). Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
fahedouch
pushed a commit
to fahedouch/containerd
that referenced
this pull request
Aug 7, 2020
We had once updated bbolt from v1.3.3 to v1.3.4 in containerd#4134, but reverted to v1.3.3 in containerd#4156 due to "fatal error: sweep increased allocation count" (etcd-io/bbolt#214). The issue was fixed in bbolt v1.3.5 (etcd-io/bbolt#220). Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
tussennet
pushed a commit
to tussennet/containerd
that referenced
this pull request
Sep 11, 2020
We had once updated bbolt from v1.3.3 to v1.3.4 in containerd#4134, but reverted to v1.3.3 in containerd#4156 due to "fatal error: sweep increased allocation count" (etcd-io/bbolt#214). The issue was fixed in bbolt v1.3.5 (etcd-io/bbolt#220). Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
added a commit
to AkihiroSuda/containerd
that referenced
this pull request
Nov 10, 2020
We had once updated bbolt from v1.3.3 to v1.3.4 in containerd#4134, but reverted to v1.3.3 in containerd#4156 due to "fatal error: sweep increased allocation count" (etcd-io/bbolt#214). The issue was fixed in bbolt v1.3.5 (etcd-io/bbolt#220). Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> (cherry picked from commit bebfbab) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT (by @AkihiroSuda): this was reverted in #4156
full diff: etcd-io/bbolt@v1.3.3...v1.3.4
As mentioned in #4050 (comment) - this update fixes issues when using Go 1.14 / revealed by Go 1.14