Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Implement CRI Debug API #359

Closed
4 tasks done
Random-Liu opened this issue Oct 26, 2017 · 18 comments
Closed
4 tasks done

Implement CRI Debug API #359

Random-Liu opened this issue Oct 26, 2017 · 18 comments
Assignees
Milestone

Comments

@Random-Liu
Copy link
Member

Random-Liu commented Oct 26, 2017

We added the verbose option in CRI to make it possible for container runtime to provide more information for debug. kubernetes/kubernetes#53965

We should implement it in cri-containerd.

Functions we need to change:

  • ContainerStatus
  • PodSandboxStatus
  • ImageStatus
  • Status

We need to:

  1. Take a look at what information is included in today's docker inspect and docker info, and properly design what debug information we should include in cri-containerd.
  2. Add those information in corresponding functions.
  3. Change crictl to consume the extra information.
@Random-Liu Random-Liu added this to the v1.0.0-beta.0 milestone Oct 26, 2017
@mikebrow mikebrow self-assigned this Oct 30, 2017
@mikebrow
Copy link
Member

Background issue:
kubernetes/kubernetes#53757

@weiwei04
Copy link
Contributor

weiwei04 commented Nov 6, 2017

If there's no one doing this, I can take a try :)

@mikebrow
Copy link
Member

mikebrow commented Nov 6, 2017

I've started it, but not far along.

@Random-Liu
Copy link
Member Author

@weiwei04 There will be various issues filed by @mikebrow or me for this in both cri-containerd and cri-tools repositories.

Feel free to pick one if you are interested. :)

@Random-Liu
Copy link
Member Author

Things might be useful for container info:

  • container config.
  • pid.
  • more

@abhi
Copy link
Member

abhi commented Nov 29, 2017

Starting on this

@mikebrow
Copy link
Member

hey ok been busy :-)

@mikebrow
Copy link
Member

"value should be in json format" grr

@mikebrow
Copy link
Member

mikebrow commented Nov 29, 2017

ok added:

Container Status:

  • container config.
  • pid.
  • removing state.
  • container runtime spec.
  • snapshotter info.

@mikebrow
Copy link
Member

See kubernetes-sigs/cri-tools#206

@Random-Liu
Copy link
Member Author

Add sandbox id in container status. We should add it into CRI eventually, but it's code freeze now.

@mikebrow
Copy link
Member

mikebrow commented Dec 1, 2017

A little back link to the pod.. ok I like it. Done (added sandbox id) see updated #452

@mikebrow
Copy link
Member

mikebrow commented Dec 1, 2017

Added:
Container Status:

  • sandboxID

Pod Status:

  • pid
  • state
  • runtimeSpec
  • snapshotter info

@mikebrow
Copy link
Member

mikebrow commented Dec 5, 2017

Added:

Image Status:

  • chainID
  • imagespec(image structure from OCI)

@mikebrow
Copy link
Member

mikebrow commented Dec 5, 2017

** ok now that we've got a decent amount of debug info in the verbose mode, we need to go back and add (or consider adding) some group structs for the verbose information. This is because the order for the data in the map is random and might not make as much sense out of order as it would in some defined sequence at least for a group of items.

Eg. "snapshotInfo": { "snapshotKey": ... "snapshotter":... }

@mikebrow
Copy link
Member

mikebrow commented Dec 6, 2017

Pod and Image verbose info are ready for final review.

@mikebrow
Copy link
Member

Image verbose is ready for final review...

@Random-Liu
Copy link
Member Author

Random-Liu commented Dec 12, 2017

@mikebrow All done. I think we can close this one.

Can you add a simple document for crictl? For #96

We just need a reference somewhere in our repo.
It should point out that:

  1. We should use crictl for debugging cri-containerd.
  2. A simple example, e.g. crictl inspect.
  3. Link to crictl document.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants