Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move zfs code into root #5

Closed
crosbymichael opened this issue Jun 28, 2017 · 1 comment
Closed

Move zfs code into root #5

crosbymichael opened this issue Jun 28, 2017 · 1 comment

Comments

@crosbymichael
Copy link
Member

I think you can move the zfs code into the root of the repo so that users can just import the snapshotter without having to dig deeper. What do you think?

@AkihiroSuda
Copy link
Member

@crosbymichael

Sorry for didn't notice this github issue! 😅

I attempted to move the code into root, but could not get "static" installation working:

$ vi ~/gopath/src/github.com/containerd/containerd/cmd/containerd/builtins_zfs.go
$ go build github.com/containerd/containerd/cmd/containerd
cmd/containerd/builtins_zfs.go:5:8: import "github.com/AkihiroSuda/containerd-zfs" is a program, not an importable package

https://github.com/AkihiroSuda/containerd-zfs/compare/attempt-issue-5?expand=1

Let me know if there is a solution to fix this.

Also, I'd appreciate if you can review Makefile and vendor.conf (and also the snapshotter code itself) 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants