Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetUpVethWithName returns one veth with down #777

Closed
terassyi opened this issue Oct 14, 2022 · 3 comments
Closed

SetUpVethWithName returns one veth with down #777

terassyi opened this issue Oct 14, 2022 · 3 comments

Comments

@terassyi
Copy link

When I use containernetworking/plugins v1.1.1 SetUpVethWithName returns one veth interface with down.
Therefore, I have to set up the link after I get it.

For example, SetUpVethWithName returns contVeth with down when calling like below.
hostVeth, contVeth, err := ip.SetUpVethWithName( ... )

In PR #687, I found that the code to set up the veth is deleted.

https://github.com/containernetworking/plugins/pull/687/files#diff-a3e0f4cdf9821c455178c4ea6aeba5f7a8faf8121022a740dd65b32bace17fac

Is this an intended behavior?

Thank you in advance.

@MikeZappa87
Copy link
Contributor

Hello, what is your network configuration? I can look into this?

@dcbw
Copy link
Member

dcbw commented Oct 17, 2022

@terassyi yes, that must now be done by caller code. This was done to ensure that any required IP addressing is done before the interface is brought up, since when it's up it will begin responding to ARP requests, and may send a gratuitous ARP to announce its IP/MAC mapping. But if the IP address is assigned later, after it's UP, it won't do that.

@terassyi
Copy link
Author

Thank you for your comment.

I understand that I have to set links up after I get them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants