[release-1.24] bump github.com/containers/storage from v1.38.3 to v1.38.5

[nalind]

What type of PR is this?

/kind other

What this PR does / why we need it:

Update github.com/containers/storage from v1.38.3 to v1.38.5, pulling in cherry-picked containers/storage#1244 and containers/storage#1274.

How to verify it

Attempt a buildah build using overlay with mount_program=/usr/bin/fuse-overlayfs when the storage root is itself on a virtiofs mount point.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

This is a bit tricky to set up for CI, but if you're root on a Fedora 36 system, fuse-overlayfs over fuse-overlayfs seems to be close enough to be able to verify it if you're root if you're careful about the base image:

mkdir /var/tmp/{upper,work,lower}
fuse-overlayfs -o upperdir=/var/tmp/upper,lowerdir=/var/tmp/lower,workdir=/var/tmp/work /var/lib/containers
cat > buildfile << EOF
FROM alpine
RUN pwd
EOF
buildah --storage-driver overlay --storage-opt mount_program=/usr/bin/fuse-overlayfs build -f buildfile

Does this PR introduce a user-facing change?

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nalind]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm
/hold

[openshift-ci]

New changes are detected. LGTM label has been removed.

[gkurz]

/retest

[gkurz]

Hi @rhatdan, is it possible to retry the smoke test ?

[rhatdan]

Restarted.

[gkurz]

Restarted.

@rhatdan Thanks but it seems to be failing again...

[rhatdan]

@cevich Any idea what is happening here?

[cevich]

That's bad. I just checked, and there's no release-1.24 Cirrus-Cron build setup.. Meaning the meta task hasn't run and the VM images may have been pruned. Let me see if I can recover them...

[cevich]

...sigh, we're screwd on the c4764556961513472 images, they're gone-gone. This is at least partly or fully my fault...I clearly wasn't paying attention and should have added that cirrus-cron job to keep them alive. I've also had on my TODO list for a while to add some kind of "don't ever deprecate this image" mechanism 😢

Plan B: Is there a podman release branch that roughly corresponds to the buildah 1.24 timeframe? Assuming so, we can simply steal the image ID from that podman branch and use it here.

[rhatdan]

SGTM

[cevich]

Poking around I found the podman v4.0 branch is using identical OS versions (packages may be a bit newer or older). More importantly, the images are still alive. Use c5814666029957120 here (in .cirrus.yml) and the tests should start working. I'll also go ahead and add this branch into the cirrus-cron list to prevent this happening again.