Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/containers/storage from v1.38.3 to v1.38.5 #4106

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 12, 2022

What type of PR is this?

/kind other

What this PR does / why we need it:

Update github.com/containers/storage from v1.38.3 to v1.38.5, pulling in cherry-picked containers/storage#1244 and containers/storage#1274.

How to verify it

Attempt a buildah build using overlay with mount_program=/usr/bin/fuse-overlayfs when the storage root is itself on a virtiofs mount point.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

This is a bit tricky to set up for CI, but if you're root on a Fedora 36 system, fuse-overlayfs over fuse-overlayfs seems to be close enough to be able to verify it if you're root if you're careful about the base image:

mkdir /var/tmp/{upper,work,lower}
fuse-overlayfs -o upperdir=/var/tmp/upper,lowerdir=/var/tmp/lower,workdir=/var/tmp/work /var/lib/containers
cat > buildfile << EOF
FROM alpine
RUN pwd
EOF
buildah --storage-driver overlay --storage-opt mount_program=/usr/bin/fuse-overlayfs build -f buildfile

Does this PR introduce a user-facing change?

None

Update github.com/containers/storage from v1.38.3 to v1.38.5.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Member Author

rhatdan commented Jul 12, 2022

Replaces: #4084

Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cirrus updates LGTM.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat
Copy link
Member

LGTM
/hold #for happy tests

@openshift-ci openshift-ci bot merged commit 63813ef into containers:release-1.24 Jul 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants