Compilation error with clang++ 17

[Ecordonnier]

I am trying to consume libcrun in a c++ program compiled with clang++ 17 by including libcrun/container.h in "extern C" blocks.

#ifdef __cplusplus
extern "C" {
#include <libcrun/container.h>
#endif

#ifdef __cplusplus
}
#endif

The issue is that container.h includes ocispec/runtime_spec_schema_config_schema.h, which contains the following code which uses the reserved c++ keyword "class":

typedef struct {
    char *class;
    int32_t priority;
    yajl_val _residual;
    unsigned int priority_present : 1;
}

Thus the compilation fails.

I am not familiar with the crun repository. Should this be fixed by replacing the "class" keyword while generating the C header-file in https://github.com/containers/libocispec/blob/main/src/ocispec/headers.py ?

[giuseppe]

yes, I think we need to solve that by changing class with something else. Perhaps adding a underscore at the end?

This must be solved in the libocispec repo though: https://github.com/containers/libocispec

[Ecordonnier]

yes, I think we need to solve that by changing class with something else. Perhaps adding a underscore at the end?

This must be solved in the libocispec repo though: https://github.com/containers/libocispec

OK, I cloned the issue to containers/libocispec#132 . Do you want to close this one?

[giuseppe]

thanks, closing it now