refactor logging

[giuseppe]

the logging (src/libcrun/error.c) is currently a mess, it needs to be simplified and polished

[dmolik]

would this be a good time to bring up logging to syslog?

[giuseppe]

@dmolik if you need that, I can try to add it in the current mess :-)

Is it anything runc already does and we need to keep some CLI compatibility? If not, would something like --log=syslog:IDENTITY be good for you?

[giuseppe]

@dmolik I've opened https://github.com/giuseppe/crun/pull/28

It is still work in progress, but you can start using syslog, like crun --log=syslog: and journald as crun --log=journald:. If not specified, they both use the container name as the identifier, otherwise they use whatever is specified after :. So for example if you want to override an identifier in the logging, you can do: crun --log=syslog:FOO.

What do you think?

[dmolik]

Setting the facility name would be cool.

[giuseppe]

I've implemented that functionality in the PR.

You can use --log=syslog:IDENTITY to override the identifier, otherwise it defaults to the container name. Similarly for --log=journald:

[giuseppe]

is that enough for you? :-) Can I merge the PR?

[dmolik]

LGTM. Thanks! Sorry for the slow response.

[rhatdan]

@giuseppe Should this issue be closed?

[rhatdan]

@giuseppe Can we close?

[giuseppe]

yes, let's close it as there is no work going on and it is not really a specific issue