Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v5.16-rhel, backport] storage: use race-free AddNames instead of SetNames #1519

Merged
merged 3 commits into from
Apr 6, 2022
Merged

[v5.16-rhel, backport] storage: use race-free AddNames instead of SetNames #1519

merged 3 commits into from
Apr 6, 2022

Commits on Apr 6, 2022

  1. Remove keyring support 

    The package is not used, noone is currently working on wiring it up,
and it started failing in CI (apparently because it assumes the user's
keyring is empty when tests start, which is now not reliably the case).

Instead of fixing the tests, just remove it; we can always restore
the code from Git history.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
    @mtrmac @flouthoc
    mtrmac authored and flouthoc committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    4030991 View commit details
    Browse the repository at this point in the history

  2. vendor: bump c/storage to v1.36.3 

    Signed-off-by: Aditya R <arajan@redhat.com>
    @flouthoc
    flouthoc committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    d2eb9e6 View commit details
    Browse the repository at this point in the history

  3. storage: use race-free AddNames instead of SetNames 

    Commits from parallel builds using `SetNames` removes `names` from
storage for other builds.

Use race-free atomic `AddNames` to prevent breaking of parallel builds.

Signed-off-by: Aditya R <arajan@redhat.com>
    @flouthoc
    flouthoc committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    bbe074b View commit details
    Browse the repository at this point in the history