Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oci: flip ShouldCompressLayers to always true #179

Merged
merged 1 commit into from
Dec 5, 2016
Merged

oci: flip ShouldCompressLayers to always true #179

merged 1 commit into from
Dec 5, 2016

Conversation

cyphar
Copy link
Contributor

@cyphar cyphar commented Dec 3, 2016

Fixes #178
Signed-off-by: Aleksa Sarai asarai@suse.de

Signed-off-by: Aleksa Sarai <asarai@suse.de>
@cyphar
Copy link
Contributor Author

cyphar commented Dec 5, 2016

@mtrmac I just played around with this and I think this fixes #178 "well enough" for my own testing and usage.

@runcom
Copy link
Member

runcom commented Dec 5, 2016

I believe this will break the docker integration for save/load since I'm compressing in docker right now and PutBlob(compressed-stream)

@mtrmac
Copy link
Collaborator

mtrmac commented Dec 5, 2016

@runcom If docker/docker is calling PutBlob directly, this should make no difference; copy.Image cares about ShouldCompressLayers, not PutBlob.

(This LGTM but a formal 👍 pending on resolving @runcom ’s worry.)

@runcom
Copy link
Member

runcom commented Dec 5, 2016

👍 @mtrmac awesome then

Approved with PullApprove

@runcom
Copy link
Member

runcom commented Dec 5, 2016

lgtm

pullapprove--

@mtrmac
Copy link
Collaborator

mtrmac commented Dec 5, 2016

👍

Approved with PullApprove

@mtrmac mtrmac merged commit f696799 into containers:master Dec 5, 2016
@cyphar cyphar deleted the 178-fix-docker-to-oci-gzip branch December 5, 2016 16:50
giuseppe pushed a commit to giuseppe/image that referenced this pull request Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants