Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout broken for a "Play pod or Container from a Kubernetes YAML" after sucessfull pod creation #2621

Closed
odockal opened this issue May 24, 2023 · 2 comments · Fixed by #3050
Closed

Layout broken for a "Play pod or Container from a Kubernetes YAML" after sucessfull pod creation #2621

odockal opened this issue May 24, 2023 · 2 comments · Fixed by #3050
Assignees
@cdrage
Labels
area/kubernetes ☸️ kind/bug 🐞 Something isn't working

Comments

@odockal
Copy link
Contributor

odockal commented May 24, 2023

Bug description

I got broken layout, almost endless json response editor under "Done" button after "Play Kubernetes YAML".
broken-playout-play-kube-yaml

Operating system

Fedora 37

Version

1.0.x

Steps to reproduce

  1. Pull httpd-24 (quay.io/centos7/httpd-24-centos7) image
  2. Start container
  3. Create a kube from httpd container
  4. Play Kubernetes YAML with create yaml, choose podman runtime

My configuration is that I also have openshift local, kind and sandbox resources started. kube context is crc-admin right now.

Relevant log output

I am not sure if those console log are relevant:

97 index.ts:1327 Uncaught Error: Cannot read properties of undefined (reading 'log')
    at EventEmitter.<anonymous> (<anonymous>:2:7777)
    at EventEmitter.emit (VM159 sandbox_bundle:2:35718)
    at Object.onMessage (VM159 sandbox_bundle:2:47921)
(anonymous) @ index.ts:1327
emit @ VM159 sandbox_bundle:2
onMessage @ VM159 sandbox_bundle:2

Additional context

No response
@odockal odockal added the kind/bug 🐞 Something isn't working label May 24, 2023
@odockal
Copy link
Contributor Author

odockal commented May 24, 2023

The issue is also visible in the comment in the PR here: #2594

@cdrage cdrage self-assigned this Jun 27, 2023
@cdrage
Copy link
Contributor

cdrage commented Jun 27, 2023

Looks like play kubernetes YAML is broken in a few parts because this part is also broken too: #3033

I've marked this in-progress and I'll knock out both issues.

@cdrage cdrage mentioned this issue Jun 28, 2023
Merged
cdrage added a commit to cdrage/podman-desktop that referenced this issue Jun 28, 2023
@cdrage
feat: Reports warnings on failed kube deploy, fixes error out
c72f7d6 
### What does this PR do?

* Reports warnings when encountering container errors when using Play
  Kubernetes
* Fixes the error / warning output that was not appearing correctly.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#2621
Closes containers#3033

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop that referenced this issue Jun 29, 2023
@cdrage
feat: Reports warnings on failed kube deploy, fixes error out
e06c2a6 
### What does this PR do?

* Reports warnings when encountering container errors when using Play
  Kubernetes
* Fixes the error / warning output that was not appearing correctly.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#2621
Closes containers#3033

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage added a commit to cdrage/podman-desktop that referenced this issue Jun 29, 2023
@cdrage
feat: Reports warnings on failed kube deploy, fixes error out
940eaff 
### What does this PR do?

* Reports warnings when encountering container errors when using Play
  Kubernetes
* Fixes the error / warning output that was not appearing correctly.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#2621
Closes containers#3033

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@benoitf benoitf mentioned this issue Jul 5, 2023
Closed
cdrage added a commit that referenced this issue Jul 6, 2023
@cdrage
feat: Reports warnings on failed kube deploy, fixes error out (#3050)
982888c 
* feat: Reports warnings on failed kube deploy, fixes error out

### What does this PR do?

* Reports warnings when encountering container errors when using Play
  Kubernetes
* Fixes the error / warning output that was not appearing correctly.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes #2621
Closes #3033

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>

* add tests

Signed-off-by: Charlie Drage <charlie@charliedrage.com>

* make sure we check to see if containererrors is undefined first

Signed-off-by: Charlie Drage <charlie@charliedrage.com>

---------

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
mairin pushed a commit to mairin/podman-desktop that referenced this issue Jul 7, 2023
@cdrage @mairin
feat: Reports warnings on failed kube deploy, fixes error out (contai…
23408d2 
…ners#3050)

* feat: Reports warnings on failed kube deploy, fixes error out

### What does this PR do?

* Reports warnings when encountering container errors when using Play
  Kubernetes
* Fixes the error / warning output that was not appearing correctly.

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#2621
Closes containers#3033

### How to test this PR?

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <charlie@charliedrage.com>

* add tests

Signed-off-by: Charlie Drage <charlie@charliedrage.com>

* make sure we check to see if containererrors is undefined first

Signed-off-by: Charlie Drage <charlie@charliedrage.com>

---------

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrage cdrage

Labels
area/kubernetes ☸️ kind/bug 🐞 Something isn't working
Projects
Podman Desktop Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Reports warnings on failed kube deploy, fixes error out cdrage/podman-desktop
4 participants
@benoitf @cdrage @odockal @podman-desktop-bot