feat: Reports warnings on failed kube deploy, fixes error out

[cdrage]

feat: Reports warnings on failed kube deploy, fixes error out

What does this PR do?

This updates the Play Kubernetes YAML section similar to the output of "Deploy to Kubernetes".

• Reports warnings when encountering container errors when using Play
  Kubernetes
• Fixes the error / warning output that was not appearing correctly.

Screenshot/screencast of this PR

Screen.Recording.2023-06-28.at.2.43.52.PM.mov

What issues does this PR fix or reference?

Closes #2621
Closes #3033

How to test this PR?

1. Press Play Kubernetes
2. Use the following YAML:

# Save the output of this file and use kubectl create -f to import
# it into Kubernetes.
#
# Created with podman-4.5.1
apiVersion: v1
kind: Pod
metadata:
  annotations:
    io.podman.annotations.ulimit: nofile=524288:524288,nproc=7248:7248
  creationTimestamp: "2023-06-27T17:47:37Z"
  labels:
    app: reverentrobinson-pod
  name: reverentrobinson-pod
spec:
  containers:
  - image: docker.io/cdrage/helloworld:latest
    name: reverentrobinson
    ports:
    - containerPort: 80
      hostPort: 9000
    tty: true

3. Should appear correctly.
4. Try deploying again / you'll now get the correct erroring / warning.

Signed-off-by: Charlie Drage charlie@charliedrage.com

[cdrage]

TODO: Need to add tests (trying to figure out how to mock a .yaml being passed in as a selected file)

[benoitf]

@cdrage I think you can just mock window.openFileDialog and then you mock window.playKube as well

[jeffmaury]

I thought lint was checked at commit time

[benoitf]

@jeffmaury it is unless you bypass git hooks :-) (-n, --[no-]verify option on git)

[cdrage]

@jeffmaury it is unless you bypass git hooks :-) (-n, --[no-]verify option on git)

Haha yup, I had to bypass the hook so I can push out the code for those to test it out :) Lint is fixed now.

[cdrage]

Tests added 💯 ready for another review.

changes complete

[lstocchi]

By running your example i get the old error
Error: (HTTP code 500) server error - playing YAML file: adding pod to state: name "reverentrobinson-pod" is in use: pod already exists .

By debugging it, it gets in the catch and it skips your code. Do you have another yaml file to test it?

[cdrage]

By running your example i get the old error Error: (HTTP code 500) server error - playing YAML file: adding pod to state: name "reverentrobinson-pod" is in use: pod already exists .

By debugging it, it gets in the catch and it skips your code. Do you have another yaml file to test it?

That's intentional? I believe you still have the old pod running when trying to deploy.

[lstocchi]

That's intentional? I believe you still have the old pod running when trying to deploy.

I thought I followed your instruction. Have i misunderstood them? 🤔

Click play, select the yaml, deploy, everything works fine, repeat to see the error. No?

[cdrage]

That's intentional? I believe you still have the old pod running when trying to deploy.

I thought I followed your instruction. Have i misunderstood them? 🤔

Click play, select the yaml, deploy, everything works fine, repeat to see the error. No?

Yup! It's intentional. The error is appearing.

#3033 = It's showing the error.

#2621 = no more layout being broken.

Playing it twice induces the error and shows what this PR is fixing.

[lstocchi]

Ok I think i got it working by editing your yaml. Works fine, also the issue i saw with the broken layout is fixed.
Just a problem with a possible undefined value. For the rest looks good

[cdrage]

@lstocchi Thanks @lstocchi ! can you check the newest commit? I've added a change to that single line of code.

[lstocchi]

LGTM, works fine! Thanks @cdrage 🚀