New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play Kubernetes YAML does not error out despite container errors on creation. #3033
Labels
Comments
cdrage
added
status/on-hold ⏸️
On hold / will revisit later
kind/bug 🐞
Something isn't working
area/kubernetes ☸️
and removed
status/on-hold ⏸️
On hold / will revisit later
status/need-triage
labels
Jun 28, 2023
cdrage
added a commit
to cdrage/podman-desktop
that referenced
this issue
Jun 28, 2023
### What does this PR do? * Reports warnings when encountering container errors when using Play Kubernetes * Fixes the error / warning output that was not appearing correctly. ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes containers#2621 Closes containers#3033 ### How to test this PR? <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
added a commit
to cdrage/podman-desktop
that referenced
this issue
Jun 29, 2023
### What does this PR do? * Reports warnings when encountering container errors when using Play Kubernetes * Fixes the error / warning output that was not appearing correctly. ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes containers#2621 Closes containers#3033 ### How to test this PR? <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
added a commit
to cdrage/podman-desktop
that referenced
this issue
Jun 29, 2023
### What does this PR do? * Reports warnings when encountering container errors when using Play Kubernetes * Fixes the error / warning output that was not appearing correctly. ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes containers#2621 Closes containers#3033 ### How to test this PR? <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
added a commit
that referenced
this issue
Jul 6, 2023
* feat: Reports warnings on failed kube deploy, fixes error out ### What does this PR do? * Reports warnings when encountering container errors when using Play Kubernetes * Fixes the error / warning output that was not appearing correctly. ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes #2621 Closes #3033 ### How to test this PR? <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com> * add tests Signed-off-by: Charlie Drage <charlie@charliedrage.com> * make sure we check to see if containererrors is undefined first Signed-off-by: Charlie Drage <charlie@charliedrage.com> --------- Signed-off-by: Charlie Drage <charlie@charliedrage.com>
mairin
pushed a commit
to mairin/podman-desktop
that referenced
this issue
Jul 7, 2023
…ners#3050) * feat: Reports warnings on failed kube deploy, fixes error out ### What does this PR do? * Reports warnings when encountering container errors when using Play Kubernetes * Fixes the error / warning output that was not appearing correctly. ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes containers#2621 Closes containers#3033 ### How to test this PR? <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com> * add tests Signed-off-by: Charlie Drage <charlie@charliedrage.com> * make sure we check to see if containererrors is undefined first Signed-off-by: Charlie Drage <charlie@charliedrage.com> --------- Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
See "ContainerErrors".
We are able to successfully deploy, but when the containers are created, we encounter an error (such as a port being taken) but we do not error our or warn the user.
Because this error occurs after creation (we create and THEN start), we should at least warn the user that the container has been created, but the port is unavailable.
Operating system
mac M1
Installation Method
None
Version
1.1.0
Steps to reproduce
Using the following YAML:
Relevant log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: