Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbars shouldn't be in light mode #4888

Closed
deboer-tim opened this issue Nov 20, 2023 · 3 comments · Fixed by #4910
Closed

Scrollbars shouldn't be in light mode #4888

deboer-tim opened this issue Nov 20, 2023 · 3 comments · Fixed by #4910
Assignees
Labels

Comments

@deboer-tim
Copy link
Collaborator

Bug description

Since the PatternFly removal scrollbars are almost invisible because they're defaulting to light mode and render as black, and when you hover they go really light:

Screen.Recording.2023-11-20.at.12.22.59.PM.mov

I already proposed a possible fix via #4826, but #4887 is in this area as well.

Operating system

macOS 14.1

Installation Method

None

Version

next (development version)

Steps to reproduce

No response

Relevant log output

No response

Additional context

No response

@benoitf
Copy link
Collaborator

benoitf commented Nov 21, 2023

sorry @deboer-tim I didn't replied in the PR
yes I think we need to go with the color-scheme but as you proposed in a comment, it needs to be done conditionally (don't hardcode it to dark in the css file)

@deboer-tim
Copy link
Collaborator Author

Yes, the fix proposed in #4826 was purely 'quickest path to fix regression'. Now that we have #4887 we should do something dynamic instead.

Want me to do a PR based on my comment #4887 (review), or do you have a better idea?

@benoitf
Copy link
Collaborator

benoitf commented Nov 21, 2023

I'll provide a PR, I'll explore different solutions

benoitf added a commit to benoitf/desktop that referenced this issue Nov 21, 2023
fixes containers#4888
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit that referenced this issue Nov 21, 2023
fixes #4888
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants