chore: fix scrollbar colors to match light/dark mode #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes containers#4888 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
jeffmaury,
cdrage and
deboer-tim
and removed request for
a team
deboer-tim
approved these changes
Nov 21, 2023
benoitf
commented
Nov 21, 2023
Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
apply color scheme conditionally
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes #4888
How to test this PR?
unit test
but let's go to a big page, reduce the height and look at scrollbars it should look like grey with Dark mode and not dark