fix: light scrollbars and line height #4826
Conversation
After the PatternFly removal I noticed that the scrollbars on Mac are in light-mode. PF-dark was setting the color-scheme before, setting it again fixes the problem and means we can also remove the explicit text-white. (maybe some of the changes in #4803 too?) PF was also setting the line height to 0.9. I'm not tied to it, but it makes buttons, multi-line text, and preferences nav items all less tall. Maybe I'm just used to it, but I prefer a smaller window and 0.95 gets most of the way there & uses less space. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
feloy
and removed request for
a team
There was a problem hiding this comment.
I would not opt-in for this change (color-scheme), it will delay the work to have proper light/dark theme.
For the line-height, I would not follow css approach as well, it's breaking the tailwind flow
as elements are interconnected. It's making harder to have clean stuff.
|
color-scheme sets the defaults (light=white background, black text, scrollbars colors, etc, dark=black background, white text, etc). I was assuming we'd set it now to fix scrollbars (and anything else like text-white where the default is fine), then future light mode would toggle it. What is the other option? I don't think we want to custom style scrollbars or to use AFAIK Tailwind doesn't have an equivalent option to globally scale line height. Do you think we should override all the font sizes in config, change scaling/padding in all the affected components individually, or something else? |
|
Light mode fixed via #4910. I will submit separate issues and/or PRs for components affected by change in line height. |
What does this PR do?
After the PatternFly removal I noticed that the scrollbars on Mac are in light-mode. PF-dark was setting the color-scheme before, setting it again fixes the problem and means we can also remove the explicit text-white. (maybe some of the changes in #4803 too?)
PF was also setting the line height to 0.9. I'm not tied to it, but it makes buttons, multi-line text, and preferences nav items all less tall. Maybe I'm just used to it, but I prefer a smaller window and 0.95 gets most of the way there & uses less space.
Screenshot/screencast of this PR
1.5.3:
Post PatternFly:
This PR:
What issues does this PR fix or reference?
N/A
How to test this PR?
Open dashboard, preferences.