Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension error message in Error tab is not readable in light mode #7708

Closed
Tracked by #4914
cbr7 opened this issue Jun 18, 2024 · 0 comments · Fixed by #7719
Closed
Tracked by #4914

Extension error message in Error tab is not readable in light mode #7708

cbr7 opened this issue Jun 18, 2024 · 0 comments · Fixed by #7719
Assignees
@deboer-tim
Labels
area/ui kind/bug 🐞 Something isn't working

Comments

@cbr7
Copy link
Contributor

cbr7 commented Jun 18, 2024

Bug description

The error messages in the Error tab in the Extension details menu are not readable with light mode enabled.

image (5)

Operating system

macOS

Installation Method

Installer from website/GitHub releases

Version

next (development version)

Steps to reproduce

  1. Have latest PD release.
  2. Switch to light mode.
  3. Install an extension that fails to startup (e.g openshift local)
  4. Go to the extension details menu for it and click the Error tab to view the error message.
  5. Notice that the error message is not readable in light mode.

Relevant log output

No response

Additional context

No response
@cbr7 cbr7 added kind/bug 🐞 Something isn't working area/ui labels Jun 18, 2024
@deboer-tim deboer-tim self-assigned this Jun 18, 2024
@deboer-tim deboer-tim mentioned this issue Jun 18, 2024
Open
46 tasks
deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jun 18, 2024
@deboer-tim
chore: light mode for extension error
2436b97 
Set text to light mode color so that it is visible.

Fixes containers#7708.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim mentioned this issue Jun 18, 2024
Merged
@cdrage cdrage closed this as completed in b89c1f5 Jun 18, 2024
deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jun 18, 2024
@deboer-tim
chore: use color var in index.html
028536d 
We should not hardcode a default text colour to white, especially in light
mode. This is the (temporary) cause of many issues like containers#7708 where we
hadn't yet set a light mode color so you get white on light.

We don't have a 'default text color' and none of the existing palette
entries fit, so I talked to Emma and decided to create a new variable.

Unfortunately, even though this is a 'correct' change, setting it right
now has the reverse problem: anything that is still missing light mode
support will see the default text color change from white to dark and
have problems on dark backgrounds. A quick test showed the following:

- some forms (containers#7214)
- containers#7727
- containers#7728

So we should not move this out of draft until most of these are fixed,
and definitely not immediately before a release. In the meantime, it's
handy to set this to something really obvious (e.g. amber) to see what
still needs light mode support.

Fixes containers#7724.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim mentioned this issue Jun 18, 2024
Draft
cdrage pushed a commit to cdrage/podman-desktop that referenced this issue Jun 19, 2024
@deboer-tim @cdrage
chore: light mode for extension error (containers#7719)
feb5894 
Set text to light mode color so that it is visible.

Fixes containers#7708.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deboer-tim deboer-tim

Labels
area/ui kind/bug 🐞 Something isn't working
Projects
Podman Desktop Planning
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: light mode for extension error deboer-tim/desktop
2 participants
@deboer-tim @cbr7