-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light mode for status icon #7728
Labels
Comments
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this issue
Jun 18, 2024
We should not hardcode a default text colour to white, especially in light mode. This is the (temporary) cause of many issues like containers#7708 where we hadn't yet set a light mode color so you get white on light. We don't have a 'default text color' and none of the existing palette entries fit, so I talked to Emma and decided to create a new variable. Unfortunately, even though this is a 'correct' change, setting it right now has the reverse problem: anything that is still missing light mode support will see the default text color change from white to dark and have problems on dark backgrounds. A quick test showed the following: - some forms (containers#7214) - containers#7727 - containers#7728 So we should not move this out of draft until most of these are fixed, and definitely not immediately before a release. In the meantime, it's handy to set this to something really obvious (e.g. amber) to see what still needs light mode support. Fixes containers#7724. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this issue
Jun 25, 2024
The status icon is currently picking up the default text (fill) color from the parent. This is fine at the moment while the default is white, but once we set the default text color in light mode to black (see PR containers#7729) the fill color would change to black. This provides a new status color to use for the icons so that (as per design) they use their own color and do not pick up the default/parent text color. I wasn't 100% sure it should be a '--pd-status' color since this isn't a status color per se like running or stopped, but it's much more obvious that it is related to the other status colors. Related to containers#7729. Fixes containers#7728. Signed-off-by: Tim deBoer <git@tdeboer.ca>
1 task
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this issue
Jul 3, 2024
The status icon is currently picking up the default text (fill) color from the parent. This is fine at the moment while the default is white, but once we set the default text color in light mode to black (see PR containers#7729) the fill color would change to black. This provides a new status color to use for the icons so that (as per design) they use their own color and do not pick up the default/parent text color. I wasn't 100% sure it should be a '--pd-status' color since this isn't a status color per se like running or stopped, but it's much more obvious that it is related to the other status colors. Related to containers#7729. Fixes containers#7728. Signed-off-by: Tim deBoer <git@tdeboer.ca>
rostalan
pushed a commit
to rostalan/podman-desktop
that referenced
this issue
Jul 16, 2024
The status icon is currently picking up the default text (fill) color from the parent. This is fine at the moment while the default is white, but once we set the default text color in light mode to black (see PR containers#7729) the fill color would change to black. This provides a new status color to use for the icons so that (as per design) they use their own color and do not pick up the default/parent text color. I wasn't 100% sure it should be a '--pd-status' color since this isn't a status color per se like running or stopped, but it's much more obvious that it is related to the other status colors. Related to containers#7729. Fixes containers#7728. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your enhancement related to a problem? Please describe
Status icon is picking up the default text color for 'started' and likely other modes.
Describe the solution you'd like
Define any missing colors if necessary and set an explicit color.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: