Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light mode default text color (Replace text-white in index.html with color variable) #7724

Open
Tracked by #4914
deboer-tim opened this issue Jun 18, 2024 · 0 comments · May be fixed by #7729
Open
Tracked by #4914

Light mode default text color (Replace text-white in index.html with color variable) #7724

deboer-tim opened this issue Jun 18, 2024 · 0 comments · May be fixed by #7729
Assignees
@deboer-tim
Labels
area/ui kind/enhancement ✨ Issue for requesting an improvement

Comments

@deboer-tim
Copy link
Collaborator

Is your enhancement related to a problem? Please describe

I noticed that some of the light mode issues we're facing are due to text-white being set in index.html, regardless of which light/dark mode is in use.

Describe the solution you'd like

Although this is helping to find cases where the variables are missing for light mode, we should set a default text color that's appropriate to the appearance mode. Otherwise, this is just tilting things toward dark mode and making missing variables have much worse default behaviour.

Describe alternatives you've considered

No response

Additional context

No response
@deboer-tim deboer-tim added the kind/enhancement ✨ Issue for requesting an improvement label Jun 18, 2024
@deboer-tim deboer-tim self-assigned this Jun 18, 2024
@deboer-tim deboer-tim mentioned this issue Jun 18, 2024
Open
46 tasks
@deboer-tim deboer-tim changed the title Remove text-white from index.html Replace text-white in index.html with color variable Jun 18, 2024
deboer-tim added a commit to deboer-tim/desktop that referenced this issue Jun 18, 2024
@deboer-tim
chore: use color var in index.html
028536d 
We should not hardcode a default text colour to white, especially in light
mode. This is the (temporary) cause of many issues like containers#7708 where we
hadn't yet set a light mode color so you get white on light.

We don't have a 'default text color' and none of the existing palette
entries fit, so I talked to Emma and decided to create a new variable.

Unfortunately, even though this is a 'correct' change, setting it right
now has the reverse problem: anything that is still missing light mode
support will see the default text color change from white to dark and
have problems on dark backgrounds. A quick test showed the following:

- some forms (containers#7214)
- containers#7727
- containers#7728

So we should not move this out of draft until most of these are fixed,
and definitely not immediately before a release. In the meantime, it's
handy to set this to something really obvious (e.g. amber) to see what
still needs light mode support.

Fixes containers#7724.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim linked a pull request Jun 18, 2024 that will close this issue
Draft
@deboer-tim deboer-tim changed the title Replace text-white in index.html with color variable Light mode default text color (Replace text-white in index.html with color variable) Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deboer-tim deboer-tim

Labels
area/ui kind/enhancement ✨ Issue for requesting an improvement
Projects
Podman Desktop Planning
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use color var in index.html deboer-tim/desktop
4 participants
@feloy @deboer-tim @podman-desktop-bot @nichjones1