Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension-api): Allows to select a file for string properties #1104

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Jan 4, 2023

What does this PR do?

provides a file selector if formatter is set to file on string properties in properties

Screenshot/screencast of this PR

tFpBbQl4Dm.mp4

What issues does this PR fix or reference?

#185

How to test this PR?

Add in package.json of for example podman extension a new property like

        "podman.factory.machine.image-path": {
          "type": "string",
          "format": "file",
          "scope": "ContainerProviderConnectionFactory",
          "description": "Image Path (Optional)"
        }

then in settings/resources/podman, when creating a podman machine you should see a new field where you can select a file

Change-Id: Ibb5a069be31e47ccf68c9c5654478a7861e8ec89
Signed-off-by: Florent Benoit fbenoit@redhat.com

Change-Id: Ibb5a069be31e47ccf68c9c5654478a7861e8ec89
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM!

@cdrage cdrage merged commit 6ae90be into podman-desktop:main Jan 4, 2023
@podman-desktop-bot podman-desktop-bot added this to the 0.11.0 milestone Jan 4, 2023
@slemeur
Copy link
Contributor

slemeur commented Jan 9, 2023

Nice! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants