feat: add compatibility button for Linux using flatpak-spawn

[cdrage]

feat: add compatibility button for Linux using flatpak-spawn

What does this PR do?

• Uses flatpak-spawn
• Adds a compatibility button that will enable / disable the systemd
  podman.socket that allows Docker compatibility
• Refactors the runSudoHelperCommand function so that both macOS and
  Linux implementations can use it

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Closes the rest of #1447

How to test this PR?

1. Use Linux
2. yarn watch
3. Click on the compatibility mode and follow the steps to enable /
   disable.

Signed-off-by: Charlie Drage charlie@charliedrage.com

[cdrage]

Ready for review!

Works on Fedora 39 / Ubuntu but not on Debian.

Will ask you for a password when enabling / disabling as it's using systemctl to enable and disable the socket.

The warning will NOT go away due to this issue: #1928 on Linux.

[lstocchi]

Tried on fedora 37 but nothing happens apparently. Not sure if i'm expecting a different behavior or it doesn't work. I click on the compatibility button, it asks me to enable it. I authenticate. Everything seems went fine. Then if i re-click i would expect the disable workflow but it repeat the enablement.

[cdrage]

Tried on fedora 37 but nothing happens apparently. Not sure if i'm expecting a different behavior or it doesn't work. I click on the compatibility button, it asks me to enable it. I authenticate. Everything seems went fine. Then if i re-click i would expect the disable workflow but it repeat the enablement.

That's an oversight on my part, there are some issues with running yarn watch vs the binary and I've set this PR back to draft so I can fix them. The sudo-prompt isn't working correctly. Thanks for pointing this out, I was testing it via the binary only.

[cdrage]

Done, ready for another review.

Using polkit a password prompt will automatically show when running systemctl enable

Keep in mind, that the warning will ALWAYS show due to bug: #1928

See video below:

Screen.Recording.2023-04-05.at.11.09.47.AM.mov

[lstocchi]

Tried but i still don't see the disable part.

When i click on the action, the enablement (systemctl enable...) works fine but then i read in the dialog i have to execute the command ln -s ... . Can't this be performed automatically somehow?
If i click ok i don't see it anymore and i don't have any way to retrieve it. Even changing the icon on the bottom with a mark if the docker socket does not exists to remind me to do the linking would be helpful. Or atleast we could add a button copy command in the dialog so it is more clear i have to do something. Even though i'd prefer to have it working without doing anything manually.

The other problem i have is that i cannot never disable it. If i click on the compatibility action it keeps enabling it. It would be great if it disable/delete the linking/socket

[cdrage]

Tried but i still don't see the disable part.

When i click on the action, the enablement (systemctl enable...) works fine but then i read in the dialog i have to execute the command ln -s ... . Can't this be performed automatically somehow? If i click ok i don't see it anymore and i don't have any way to retrieve it. Even changing the icon on the bottom with a mark if the docker socket does not exists to remind me to do the linking would be helpful. Or atleast we could add a button copy command in the dialog so it is more clear i have to do something. Even though i'd prefer to have it working without doing anything manually.

The other problem i have is that i cannot never disable it. If i click on the compatibility action it keeps enabling it. It would be great if it disable/delete the linking/socket

Unfortunately it's because of "Keep in mind, that the warning will ALWAYS show due to bug: #1928"

I did automate the sudo ln -s but unfortunately there was ANOTHER bug with polkit not asking for authentication under flatpak-spawn --host sudo, but it works with flatpak-spawn --host systemctl

[cdrage]

@lstocchi Figured it out! Was able to use pkexec successfully and added the ability to create a ln -s command that will run.

NOTE: Still wont get rid of the warning due to #1928 but at least compatibility mode will work with CLI tools

Ready for another review @lstocchi and @benoitf

Screen.Recording.2023-04-12.at.11.11.36.AM.mov

[lstocchi]

Tested. LGTM. GJ!! 🚀

I can see the docker.sock created correctly and it works as expected.

My only concern is that we should fix #1928 before release with this patch otherwise it is confusing.

[lstocchi]

Reapproving as i use the gh filter to see which PRs i need to review 😆

[cdrage]

This was requested in the Discord recently with regards to the status of it.

I"ve gone ahead and rebased it. Could use with another review / possible merge!

[benoitf]

checked still working on macOS

[cdrage]

Merging as we've got one approval from @lstocchi who tested on Linux, and @benoitf made sure that functionality still works on macOS with the other changes added.

Thanks! 💯